Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DeepL as translation service #2

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Add DeepL as translation service #2

merged 3 commits into from
Sep 19, 2024

Conversation

Elhebert
Copy link
Contributor

Hi 👋

Nice package!

I figured it would be nice to also include DeepL as a translation service. This will give an opportunity to the privacy focused people an alternative to OpenAI and Google Translate.

I’m marking the PR as a draft since I want to test the integration in a real Laravel app before I mark the PR as done.

tests/Translator/DeeplTranslatorTest.php Outdated Show resolved Hide resolved
tests/Translator/DeeplTranslatorTest.php Outdated Show resolved Hide resolved
@Bottelet
Copy link
Owner

This is great! Let me know how the testing goes, and i will merge it.

@Elhebert Elhebert marked this pull request as ready for review September 19, 2024 15:10
@Elhebert
Copy link
Contributor Author

@Bottelet I did a test locally on a personal project, works like a charm with DeepL 👌

@Bottelet
Copy link
Owner

This is great I appreciate the contribution! 🙌

@Bottelet Bottelet merged commit e58f202 into Bottelet:main Sep 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants