use null as default value for none translated string, as null default…

… back to the key
Bottelet · Sep 19, 2024 · ff17fc0 · ff17fc0
1 parent 72aed23
commit ff17fc0
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/Finder/MissingKeysFinder.php b/src/Finder/MissingKeysFinder.php
@@ -56,7 +56,7 @@ protected function extractMissingTranslations(array $foundStrings, array $jsonTr
         foreach ($foundStrings as $string) {
             $string = stripslashes($string);
             if (! array_key_exists($string, $jsonTranslations)) {
-                $missingTranslations[$string] = $string;
+                $missingTranslations[$string] = null;
             }
         }
 

diff --git a/tests/Finder/MissingKeysFinderTest.php b/tests/Finder/MissingKeysFinderTest.php
@@ -138,13 +138,13 @@ public function findMissingTranslationsFindsPersistentKeysFromConfig(): void
 
 
     #[Test]
-    public function findMissingTranslatableStringUseKeyAsDefaultValue(): void
+    public function findMissingTranslatableStringUseNullAsDefaultValue(): void
     {
         $multiFunctionFile = $this->createTempFile('multiFunction.php', "<?php echo __('da.key.test'); __('a long string');");
         $translationFinder = new MissingKeysFinder;
 
         $foundStrings = $translationFinder->findMissingTranslatableStrings([$multiFunctionFile], []);
-        $this->assertSame(['da.key.test' => 'da.key.test', 'a long string' => 'a long string'], $foundStrings);
+        $this->assertSame(['da.key.test' => null, 'a long string' => null], $foundStrings);
 
     }
 }
diff --git a/tests/TranslationManagerTest.php b/tests/TranslationManagerTest.php
@@ -77,9 +77,9 @@ public function translationsAreAppendedWhenNotUsingTranslationService(): void
             $this->jsonFilePath
         );
         $this->assertEquals([
-            'app.title'       => 'app.title',
-            'Something cool ' => 'Something cool ',
-            'greeting'        => 'greeting',
+            'app.title'       => null,
+            'Something cool ' => null,
+            'greeting'        => null,
         ], $missingTranslations);
     }