Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alexa] Add Alexa Adapter #157

Merged
merged 6 commits into from
Feb 14, 2020
Merged

[Alexa] Add Alexa Adapter #157

merged 6 commits into from
Feb 14, 2020

Conversation

iMicknl
Copy link
Contributor

@iMicknl iMicknl commented Feb 11, 2020 •
edited
Loading

Currently not supported scenarios;

  • Add proactive events to your skill (documentation)
  • Specify Alexa RePrompt speech / text
  • Account Linking Management (documentation)
  • Directives other than display
  • CanFulfillIntentRequest
  • Alexa Reminders (documentation)
  • Add Personalization to Your Skils (documentation) + ([documentation](Add Personalized Greetings or Prompts))
  • Enhance Your Skill With Address Information (documentation)
  • Location Services for Alexa Skills (documentation)

ToDo for final version:

  • Improve test coverage
  • Work on all todo's in code
  • Extensive code review

.NET parity:

  • .NET has extended turncontext with an internal class. It has a collection of activities on, which gets built up overtime. The activities essentially get carried around with the context.T hen the adapter grabs them at the end off the context.

@szul @garypretty hereby the first preview of the Alexa Adapter. I have tried to keep it as close possibly to the .NET adapter and to the JavaScript BotBuilder patterns. Feedback is welcome.

Currently published as 1.0.0-beta001 package on npm and it can be downloaded by using the @next tag. Documentation.

Closes #114

@iMicknl iMicknl requested review from szul and a team February 11, 2020 23:20
@iMicknl iMicknl self-assigned this Feb 11, 2020
@iMicknl iMicknl mentioned this pull request Feb 11, 2020
Closed
@iMicknl iMicknl requested a review from garypretty February 11, 2020 23:20
@szul szul linked an issue Feb 12, 2020 that may be closed by this pull request
Port Alexa adapter from C# to JS #114
Closed
@szul szul mentioned this pull request Feb 12, 2020
Open
@v-kydela v-kydela merged commit 1f1b479 into BotBuilderCommunity:develop Feb 14, 2020
@iMicknl
Copy link
Contributor Author

iMicknl commented Feb 14, 2020

@v-kydela why has this been merged already? It is still in preview, like the .NET package.

@v-kydela
Copy link

v-kydela commented Feb 14, 2020 •
edited
Loading

@iMicknl - The fact that you made a PR indicated to me that you wanted this to be merged. I too am working on a feature that isn't ready to be merged, but I'm not going to make a PR until I want to merge it. Sorry for merging your PR prematurely.

I do not know why this PR kept telling me that my review was requested since I don't see myself on the list of reviewers.

@iMicknl
Copy link
Contributor Author

iMicknl commented Feb 15, 2020

No worries, it is still in develop. I made the PR to get some feedback and it was ready to merge after all the feedback.

iMicknl added a commit to iMicknl/botbuilder-community-js that referenced this pull request Mar 20, 2020
@iMicknl
Squashed commit of the following:
876e4c0 
commit 097923e
Author: Mick Vleeshouwer <[email protected]>
Date:   Fri Mar 20 16:46:03 2020 +0100

    Sync master -> develop (BotBuilderCommunity#164)

    * Adaptive card dialog needed to be added to export

    * Audit fix

    Co-authored-by: Michael Szul <[email protected]>

commit 1f1b479
Merge: 7a44067 d2ba4e6
Author: Kyle Delaney <[email protected]>
Date:   Fri Feb 14 08:54:46 2020 -0800

    Merge pull request BotBuilderCommunity#157 from iMicknl/adapter/alexa

    [Alexa] Add Alexa Adapter

commit d2ba4e6
Author: Mick Vleeshouwer <[email protected]>
Date:   Fri Feb 14 16:03:49 2020 +0100

    Update dependencies

commit 8af037e
Author: Mick Vleeshouwer <[email protected]>
Date:   Fri Feb 14 16:02:03 2020 +0100

    Bugfix: don’t break on unsupported activities

commit 2c88331
Author: Mick Vleeshouwer <[email protected]>
Date:   Wed Feb 12 00:44:43 2020 +0100

    Update sample to the beta package

commit 216d18b
Author: Mick Vleeshouwer <[email protected]>
Date:   Wed Feb 12 00:40:59 2020 +0100

    Update publish config

commit 17791d0
Author: Mick Vleeshouwer <[email protected]>
Date:   Wed Feb 12 00:31:40 2020 +0100

    Minor changes in documentation and version number

commit d1eee53
Author: Mick Vleeshouwer <[email protected]>
Date:   Wed Feb 12 00:14:48 2020 +0100

    First preview version of Alexa Adapter

commit 7a44067
Merge: fa478f7 f1a469d
Author: Michael Szul <[email protected]>
Date:   Tue Feb 11 07:44:09 2020 -0500

    Merge pull request BotBuilderCommunity#156 from BotBuilderCommunity/master

    Updated .npmignore to remove .nyc_output

commit fa478f7
Merge: b8922d8 dd860af
Author: Michael Szul <[email protected]>
Date:   Tue Feb 11 07:35:48 2020 -0500

    Merge pull request BotBuilderCommunity#154 from BotBuilderCommunity/master

    [Twilio-WhatsApp] Add support for location messages (inbound & o… (BotBuilderCommunity#142)
iMicknl added a commit to iMicknl/botbuilder-community-js that referenced this pull request Mar 20, 2020
@iMicknl
Squashed commit of the following:
03843bf 
commit fa80f07
Author: Mick Vleeshouwer <[email protected]>
Date:   Fri Mar 20 16:55:40 2020 +0100

    Merge pull request BotBuilderCommunity#163

    [Core] Update all packages to botbuilder 4.8.0 and correct multiple package-lock.json BotBuilderCommunity#163

commit 097923e
Author: Mick Vleeshouwer <[email protected]>
Date:   Fri Mar 20 16:46:03 2020 +0100

    Sync master -> develop (BotBuilderCommunity#164)

    * Adaptive card dialog needed to be added to export

    * Audit fix

    Co-authored-by: Michael Szul <[email protected]>

commit 1f1b479
Merge: 7a44067 d2ba4e6
Author: Kyle Delaney <[email protected]>
Date:   Fri Feb 14 08:54:46 2020 -0800

    Merge pull request BotBuilderCommunity#157 from iMicknl/adapter/alexa

    [Alexa] Add Alexa Adapter

commit d2ba4e6
Author: Mick Vleeshouwer <[email protected]>
Date:   Fri Feb 14 16:03:49 2020 +0100

    Update dependencies

commit 8af037e
Author: Mick Vleeshouwer <[email protected]>
Date:   Fri Feb 14 16:02:03 2020 +0100

    Bugfix: don’t break on unsupported activities

commit 2c88331
Author: Mick Vleeshouwer <[email protected]>
Date:   Wed Feb 12 00:44:43 2020 +0100

    Update sample to the beta package

commit 216d18b
Author: Mick Vleeshouwer <[email protected]>
Date:   Wed Feb 12 00:40:59 2020 +0100

    Update publish config

commit 17791d0
Author: Mick Vleeshouwer <[email protected]>
Date:   Wed Feb 12 00:31:40 2020 +0100

    Minor changes in documentation and version number

commit d1eee53
Author: Mick Vleeshouwer <[email protected]>
Date:   Wed Feb 12 00:14:48 2020 +0100

    First preview version of Alexa Adapter

commit 7a44067
Merge: fa478f7 f1a469d
Author: Michael Szul <[email protected]>
Date:   Tue Feb 11 07:44:09 2020 -0500

    Merge pull request BotBuilderCommunity#156 from BotBuilderCommunity/master

    Updated .npmignore to remove .nyc_output

commit fa478f7
Merge: b8922d8 dd860af
Author: Michael Szul <[email protected]>
Date:   Tue Feb 11 07:35:48 2020 -0500

    Merge pull request BotBuilderCommunity#154 from BotBuilderCommunity/master

    [Twilio-WhatsApp] Add support for location messages (inbound & o… (BotBuilderCommunity#142)
iMicknl added a commit that referenced this pull request Mar 20, 2020
@iMicknl @szul
[Core] Add CustomWebAdapter (+OAuth) (#149)
d2b6731 
* First try for an util package

* Change to botbuilder-core & add query string parse

* Revert twilioWhatsAppAdapter.ts

* Formatting

* Audit fix

* Add README

* Update changelog

* Update documentation

* Revert twilioWhatsAppAdapter.ts

* Add OAuth support to CustomWebAdapter

* eslint fixes

* Add documentation

* Update documentation

* Bugfix for non existing settings

* Add @nestoralonsovina to credits

Used public details for now, verify if ok

* Update dependencies & fix eslint

* Update OAuth code

* ESLint fixes

* Clean up

* Update readme

* Remove emulated OAuth cards since only supported on emulator

* Update error messages

* ESLint fix

* Change USER_AGENT back to import. Update packages to 4.8.0

* Adaptive card dialog needed to be added to export

* Audit fix

* Change all dependencies to public registry

* Audit fix

* npm audit fix2

* Squashed commit of the following:

commit fa80f07
Author: Mick Vleeshouwer <[email protected]>
Date:   Fri Mar 20 16:55:40 2020 +0100

    Merge pull request #163

    [Core] Update all packages to botbuilder 4.8.0 and correct multiple package-lock.json #163

commit 097923e
Author: Mick Vleeshouwer <[email protected]>
Date:   Fri Mar 20 16:46:03 2020 +0100

    Sync master -> develop (#164)

    * Adaptive card dialog needed to be added to export

    * Audit fix

    Co-authored-by: Michael Szul <[email protected]>

commit 1f1b479
Merge: 7a44067 d2ba4e6
Author: Kyle Delaney <[email protected]>
Date:   Fri Feb 14 08:54:46 2020 -0800

    Merge pull request #157 from iMicknl/adapter/alexa

    [Alexa] Add Alexa Adapter

commit d2ba4e6
Author: Mick Vleeshouwer <[email protected]>
Date:   Fri Feb 14 16:03:49 2020 +0100

    Update dependencies

commit 8af037e
Author: Mick Vleeshouwer <[email protected]>
Date:   Fri Feb 14 16:02:03 2020 +0100

    Bugfix: don’t break on unsupported activities

commit 2c88331
Author: Mick Vleeshouwer <[email protected]>
Date:   Wed Feb 12 00:44:43 2020 +0100

    Update sample to the beta package

commit 216d18b
Author: Mick Vleeshouwer <[email protected]>
Date:   Wed Feb 12 00:40:59 2020 +0100

    Update publish config

commit 17791d0
Author: Mick Vleeshouwer <[email protected]>
Date:   Wed Feb 12 00:31:40 2020 +0100

    Minor changes in documentation and version number

commit d1eee53
Author: Mick Vleeshouwer <[email protected]>
Date:   Wed Feb 12 00:14:48 2020 +0100

    First preview version of Alexa Adapter

commit 7a44067
Merge: fa478f7 f1a469d
Author: Michael Szul <[email protected]>
Date:   Tue Feb 11 07:44:09 2020 -0500

    Merge pull request #156 from BotBuilderCommunity/master

    Updated .npmignore to remove .nyc_output

commit fa478f7
Merge: b8922d8 dd860af
Author: Michael Szul <[email protected]>
Date:   Tue Feb 11 07:35:48 2020 -0500

    Merge pull request #154 from BotBuilderCommunity/master

    [Twilio-WhatsApp] Add support for location messages (inbound & o… (#142)

Co-authored-by: Michael Szul <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szul szul Awaiting requested review from szul

@garypretty garypretty Awaiting requested review from garypretty

Assignees

@iMicknl iMicknl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port Alexa adapter from C# to JS
2 participants
@iMicknl @v-kydela