feat/add CRUD messages #152
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backmeupplz
requested changes
Jul 24, 2024
src/models/Message.ts
Outdated
| body!: string | ||
|
|
||
| @prop({ required: true }) | ||
| userId!: string |
There was a problem hiding this comment.
let's do author and link the User model here
src/controllers/message.ts
Outdated
|
|
||
| @Put('/:id') | ||
| async updateMessage(@Params('id') id: string, @Body() { content }: { content: string }) { | ||
| return await MessageModel.findByIdAndUpdate(id, { content }, { new: true }) |
There was a problem hiding this comment.
you don't have to do return await, read up on promises and why return await is unnecessary
src/controllers/message.ts
Outdated
|
|
||
| @Delete('/:id') | ||
| async deleteMessage(@Params('id') id: string) { | ||
| return await MessageModel.findByIdAndDelete |
There was a problem hiding this comment.
this won't work. test your crud with postman or insomnia
backmeupplz
requested changes
Jul 29, 2024
| body!: string | ||
|
|
||
| @prop({ required: true, ref: () => User }) | ||
| user!:Ref<User> |
There was a problem hiding this comment.
you can call it author
also turn on fix on save for the linter, your formatting is broken
make sure yarn build and yarn lint pass
| return ctx.throw(notFound()) | ||
| } | ||
|
|
||
| ctx.state['user'] = user |
There was a problem hiding this comment.
i think you can do ctx.state.user here
| @@ -0,0 +1,34 @@ | |||
| import { Context, Next } from 'koa' | |||
There was a problem hiding this comment.
call this file authenticate, as a verb
| } | ||
|
|
||
| @Delete('/:messageId') | ||
| deleteMessage(@State('message') message: DocumentType<Message>) { |
There was a problem hiding this comment.
make sure to manually test everything with postman or insomnia
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CRUD Messages