Remove usage of WBeanContainer from framework and examples #1733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
jonathanaustin
requested changes
Jun 8, 2020
| @@ -13,7 +13,7 @@ | |||
|
|
|||
| @Test | |||
| public void testChildAccessors() { | |||
| WBeanContainer container = new WBeanContainer(); | |||
There was a problem hiding this comment.
This should not really be changed as it is testing WBeanContainer.
Interestingly, there is no WContainer_Test. As this change is playing in this area, it might be worthwhile writing a WContainer_Test as well.
There was a problem hiding this comment.
Yep, makes sense. I reverted the changes in this file back to WBeanContainer.
There was a problem hiding this comment.
I added WContainer_Test.
Reverted WBeanContainer_Test to actually test WBeanContainer. Fixed some duplicate imports. Added a test for WContainer.
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the first point of #1732