Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow calculating the democratically parititoned energy when using MPI #166

Merged
merged 9 commits into from
Apr 24, 2024

Conversation

basilib
Copy link
Contributor

@basilib basilib commented Apr 23, 2024

No description provided.

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 0.00%. Comparing base (7023754) to head (84a105e).

❗ Current head 84a105e differs from pull request most recent head 4646a31. Consider uploading reports for the commit 4646a31 to get more accurate results

Files Patch % Lines
vayesta/core/qemb/rdm.py 0.00% 23 Missing ⚠️
vayesta/core/qemb/qemb.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master    #166   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files         156     156           
  Lines       20797   20807   +10     
======================================
- Misses      20797   20807   +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@basilib basilib requested a review from ghb24 April 23, 2024 23:23
Copy link
Contributor

@ghb24 ghb24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge after this comment addressed.

@@ -1263,7 +1263,7 @@ def make_rdm1_demo(self, *args, **kwargs):
def make_rdm2_demo(self, *args, **kwargs):
return make_rdm2_demo_rhf(self, *args, **kwargs)

def get_dmet_elec_energy(self, part_cumulant=True, approx_cumulant=True):
def get_dmet_elec_energy(self, part_cumulant=True, approx_cumulant=True, mpi_target=None):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include description of mpi_target in the docstring.

@basilib basilib merged commit ec4e31a into master Apr 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants