[Feat] 알림 관련 기능 구현 #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 기기 등록 / 삭제 / 조회 API (DeviceController) - 디엠 알림 / 채널생성 알림 / 리뷰이모지 알림 / 채팅채널 알림 API (NotificationController)
- 기기 등록 / 삭제 / 조회 API (DeviceController) - 디엠 알림 / 채널생성 알림 / 리뷰이모지 알림 / 채팅채널 알림 API (NotificationController)
crHwang0822
reviewed
Nov 24, 2024
notification/src/main/java/org/bookwoori/notification/config/MongoConfig.java
Outdated
Show resolved
Hide resolved
notification/src/main/java/org/bookwoori/notification/config/RedisConfig.java
Show resolved
Hide resolved
notification/src/main/java/org/bookwoori/notification/controller/DeviceController.java
Outdated
Show resolved
Hide resolved
notification/src/main/java/org/bookwoori/notification/controller/DeviceController.java
Outdated
Show resolved
Hide resolved
notification/src/main/java/org/bookwoori/notification/controller/DeviceController.java
Outdated
Show resolved
Hide resolved
notification/src/main/java/org/bookwoori/notification/dto/request/ChannelMessageRequest.java
Outdated
Show resolved
Hide resolved
notification/src/main/java/org/bookwoori/notification/dto/response/DeviceResponse.java
Outdated
Show resolved
Hide resolved
notification/src/main/java/org/bookwoori/notification/exception/CustomExceptionStatus.java
Outdated
Show resolved
Hide resolved
notification/src/main/java/org/bookwoori/notification/dto/request/EmojiMessageRequest.java
Outdated
Show resolved
Hide resolved
notification/src/main/java/org/bookwoori/notification/util/MessageType.java
Show resolved
Hide resolved
gkdudans
requested changes
Nov 24, 2024
notification/src/main/java/org/bookwoori/notification/controller/DeviceController.java
Outdated
Show resolved
Hide resolved
|
|
||
| @Operation(summary = "등록 정보 조회", description = "등록 정보를 조회합니다.") | ||
| @GetMapping("/{id}") | ||
| public DataResponse<DeviceResponse> getDevice(@PathVariable("id") Long userId) { |
There was a problem hiding this comment.
❓ResponseEntity<?>와 ResponseEntity가 아닌 ResponseService를 따로 생성해서 응답하는 이유가 있는 건가요?
notification/src/main/java/org/bookwoori/notification/dto/request/ChatMessageRequest.java
Outdated
Show resolved
Hide resolved
notification/src/main/java/org/bookwoori/notification/dto/response/DeviceResponse.java
Outdated
Show resolved
Hide resolved
|
|
||
| // Custom exception | ||
| @ExceptionHandler(CustomException.class) | ||
| @ResponseStatus(HttpStatus.BAD_REQUEST) |
There was a problem hiding this comment.
❓ExceptionAdvice는 예외 처리를 위한 GlobalExceptionHandler 역할을 하는 거 맞나요? 목적이 같다면 Core 서버 및 다른 서버에서 사용하고 있는 공통된 ErrorDto 및 GlobalExceptionHandler를 사용하면 좋을 거 같습니닷
|
|
||
| Device newDevice = Device.register(request.getUserId(), request.getPlatform(), request.getToken()); | ||
| deviceRepository.save(newDevice); | ||
| } |
There was a problem hiding this comment.
❓Device 엔티티의 register 생성 메서드를 통해 생성해야 하는 특별한 이유가 있나요? requestDto에서 toEntity 및 builder 이용해서 생성하고 save해도 되지 않나욤
| Device device = deviceRepository.findByUserId(userId) | ||
| .orElseThrow(() -> new CustomException(EMPTY_DEVICE)); | ||
| device.delete(); | ||
| } |
There was a problem hiding this comment.
❓마찬가지로 Device 엔티티에 delete() 메서드를 둬야 할 이유가 있을까요? Repository에서 delete하면 되지 않나요?
crHwang0822
approved these changes
Nov 27, 2024
gkdudans
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ 구현 기능
🎯 Resolve