[Feat] 클라이밍 채널 권한 위임 / 참여자 독서 현황 조회 / 메모 수정 API #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crHwang0822
reviewed
Nov 3, 2024
core/src/main/java/org/bookwoori/core/domain/climbing/controller/ClimbingController.java
Outdated
Show resolved
Hide resolved
| @Component | ||
| @RequiredArgsConstructor | ||
| @Transactional | ||
| public class ClimbingMemberFacade { |
There was a problem hiding this comment.
💊 ClimbingMemberFacade를 따로 두지 않고 ClimbingFacade 하나로 처리해도 되지 않을까요? Server 도메인에서는 따로 구분하지 않았어서 말해봅니당
There was a problem hiding this comment.
ClimbingFacade가 너무 길어지기도 하고 Climbing 자체에 관련된 부분 / ClimbingMember 관련된 부분으로 나누어도 괜찮을 거 같아서 그렇게 만들었는데 하나로 합치는 게 좋을까욤
core/src/main/java/org/bookwoori/core/domain/climbing/facade/ClimbingMemberFacade.java
Show resolved
Hide resolved
core/src/main/java/org/bookwoori/core/domain/climbing/facade/ClimbingMemberFacade.java
Show resolved
Hide resolved
core/src/main/java/org/bookwoori/core/domain/climbing/facade/ClimbingMemberFacade.java
Show resolved
Hide resolved
core/src/main/java/org/bookwoori/core/domain/climbingMember/service/ClimbingMemberService.java
Show resolved
Hide resolved
core/src/main/java/org/bookwoori/core/domain/record/service/RecordService.java
Show resolved
Hide resolved
join fetch 사용해서 N+1 문제 해결
진행 종료된 클라이밍 채널 편집 불가능
crHwang0822
reviewed
Nov 7, 2024
core/src/main/java/org/bookwoori/core/domain/climbingMember/service/ClimbingMemberService.java
Show resolved
Hide resolved
crHwang0822
reviewed
Nov 7, 2024
| @@ -32,11 +32,10 @@ public Member getCurrentMember() throws CustomException { | |||
| return member; | |||
| } | |||
|
|
|||
| @Transactional(readOnly = true) | |||
| public void getMemberStatus(Long kakaoId){ | |||
| public void getMemberStatus(Long kakaoId) { | |||
There was a problem hiding this comment.
❓ 이거 계정 삭제 API랑 상관 있는 메소드인가요??
There was a problem hiding this comment.
OAuth2SuccessHandler에서 토큰 발급 시 삭제한 멤버 예외 처리를 위해 사용하고 있습니단
There was a problem hiding this comment.
아 커밋명이 계정삭제 API 오류 수정 이라 여쭤봤습니당
그리고 다음 PR 때 MeController랑 MeFacade 클래스 이름도 Member~. 로 수정해주시면 감사하겠습니닷 🙇♀️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ 구현 기능
📝 구현 방법
🎯 Resolve