Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSX file in components folder #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

JSX file in components folder #2

wants to merge 2 commits into from

Conversation

BookOfGreg
Copy link
Owner

JSX Example in Webpack

mberlanda
mberlanda approved these changes Jul 31, 2018
View reviewed changes
Copy link

@mberlanda mberlanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine! It would be worth to merge it

@BookOfGreg
Copy link
Owner Author

Yep thanks.
These PRs are open to show folks what's different between the branches, not actually for merging 👍
I should probably document that one day.

@mberlanda
Copy link

Ok thanks! Are you planning to do one for server side rendering in the controller?

@BookOfGreg
Copy link
Owner Author

BookOfGreg commented Aug 1, 2018 •
edited
Loading

I wasn't because it's really easy, just call render component: and it will.
If you would like to make a branch with that on it, I will gladly accept one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mberlanda mberlanda mberlanda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BookOfGreg @mberlanda