Drop old node versions #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonaswalden
reviewed
Jun 19, 2024
lib/Element.js
Outdated
| throw new DOMException("Failed to execute 'replaceChild' on 'Node': parameter 2 is not of type 'Node'."); | ||
| replaceChildren(newChildren) { | ||
| while (this.lastChild) { | ||
| this.removeChild(this.lastChild); |
There was a problem hiding this comment.
Not sure if this is an issue but removeChild / appendChild methods emits _insert events. Might result in an active mutation observer triggering multiple times during the execution of this method, rather than once after. Is this expected behavior? Otherwise might be proper to use cheerio internally
There was a problem hiding this comment.
Aaah, no, I just moved an implementation that we had in flamingo into tallahassee so that I could remove our local override of the class. I am not super familiar with hos these things are done in tallahassee, but I will look over the implementation!
| @@ -40,8 +40,8 @@ module.exports = class WebPage { | |||
| method: "GET", | |||
| headers: requestHeaders, | |||
| }); | |||
| assert.equal(resp.status, statusCode, `Unexepected status code. Expected: ${statusCode}. Actual: ${resp.statusCode}`); | |||
| assert(resp.headers.get("content-type").match(/text\/html/i), `Unexepected content type. Expected: text/html. Actual: ${resp.headers["content-type"]}`); | |||
| assert.equal(resp.status, statusCode, `Unexepected status code. Expected: ${statusCode}. Actual: ${resp.status} (GET ${uri})`); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: