Add missing titles to product mapping

config/print-mapping.js → config/product-mapping.js

@@ -11,6 +11,10 @@ const productConfig = {
       diTitle: "Dagens Nyheter",
       complaintSenderId: "1160",
     },
+    {
+      title: "kp",
+      productName: "Kamratposten",
+    },
   ],
   di: [
     {
@@ -57,6 +61,10 @@ const productConfig = {
       diCustomerSystem: "EXPA",
       diTitle: "EX Expressen",
     },
+    {
+      title: "sportexpressen",
+      productName: "SportExpressen",
+    },
     {
       title: "gt",
       tsCode: "0760",
@@ -459,6 +467,14 @@ const productConfig = {
       productName: "Bärgslagsbladet",
       diCustomerSystem: "BARG",
     },
+    {
+      title: "bblat",
+      productName: "Bbl/AT",
+    },
+    {
+      title: "bp",
+      productName: "Bandypuls",
+    },
     {
       title: "bt",
       alternativeTitles: [ "borlangetidning" ],
@@ -509,6 +525,10 @@ const productConfig = {
       productName: "Falu-Kuriren",
       diCustomerSystem: "",
     },
+    {
+      title: "frp",
+      productName: "Folkracepuls",
+    },
     {
       title: "gd",
       alternativeTitles: [ "gefledagblad" ],
@@ -529,6 +549,10 @@ const productConfig = {
       productName: "Helsingborgs Dagblad",
       diCustomerSystem: "HELD",
     },
+    {
+      title: "hp",
+      productName: "Hockeypuls",
+    },
     {
       title: "ht",
       alternativeTitles: [ "hudiksvalsstidning", "hudiksvallstidning" ],
@@ -539,6 +563,10 @@ const productConfig = {
       productName: "Hudiksvalls Tidning",
       diCustomerSystem: "",
     },
+    {
+      title: "jnytt",
+      productName: "Jnytt",
+    },
     {
       title: "jp",
       alternativeTitles: [ "jonkopingsposten" ],
@@ -619,6 +647,10 @@ const productConfig = {
       productName: "Nerikes Allehanda",
       diCustomerSystem: "NAA",
     },
+    {
+      title: "nio",
+      productName: "Nu i Österåker",
+    },
     {
       title: "nst",
       alternativeTitles: [ "norraskanetidning" ],
@@ -659,6 +691,10 @@ const productConfig = {
       productName: "Nynäshamns Posten",
       diCustomerSystem: "NYP",
     },
+    {
+      title: "nvp",
+      productName: "Nacka Värmdö Posten",
+    },
     {
       title: "oa",
       alternativeTitles: [ "ornskoldsvikallehanda" ],
@@ -739,6 +775,10 @@ const productConfig = {
       productName: "Söderhamns Kuriren",
       diCustomerSystem: "",
     },
+    {
+      title: "sn",
+      productName: "Skövde Nyheter",
+    },
     {
       title: "sdt",
       alternativeTitles: [ "sodradalarnestidning" ],
@@ -799,6 +839,10 @@ const productConfig = {
       productName: "Tranås Tidning",
       diCustomerSystem: "TTI",
     },
+    {
+      title: "trp",
+      productName: "Tranås-Posten",
+    },
     {
       title: "vlt",
       alternativeTitles: [ "vastmanlandslanstidning" ],

lib/titles.js

@@ -1,4 +1,4 @@
-import productConfig from "../config/print-mapping.js";
+import productConfig from "../config/product-mapping.js";
 
 const postalDeliveryAllowedTitles = [ "dn", "paf", "plg" ];
 
@@ -28,17 +28,27 @@ Object.keys(productConfig).forEach((namespace) => {
 });
 
 function getAllPrintTitles() {
-  return productMapping.filter((pm) => pm.title).map((pm) => pm.title);
+  return productMapping.filter((pm) => pm.tsCode).map((pm) => pm.title);
 }
 
 function getPrintTitlesByNamespace(namespace) {
+  return productConfig[namespace].filter((pm) => pm.tsCode).map((pm) => pm.title).filter((t) => t);
+}
+
+function getAllTitles() {
+  return productMapping.filter((pm) => pm.title).map((pm) => pm.title);
+}
+
+function getTitlesByNamespace(namespace) {
   return productConfig[namespace].map((pm) => pm.title).filter((t) => t);
 }
 
 export {
   postalDeliveryAllowed,
   getAllPrintTitles,
   getPrintTitlesByNamespace,
+  getAllTitles,
+  getTitlesByNamespace,
   productMapping,
   productConfig,
 };

test/unit/titles-get-all-titles-test.js

@@ -0,0 +1,15 @@
+import { getAllTitles, getAllPrintTitles, productMapping } from "../../lib/titles.js";
+
+describe("get titles", () => {
+  it("should return all titles", () => {
+    const allTitles = getAllTitles();
+    const allTitlesFromConfig = productMapping.filter((pm) => pm.title).map((pm) => pm.title);
+    allTitles.should.eql(allTitlesFromConfig);
+  });
+
+  it("should return all print titles", () => {
+    const allTitles = getAllPrintTitles();
+    const allTitlesFromConfig = productMapping.filter((pm) => pm.tsCode).map((pm) => pm.title);
+    allTitles.should.eql(allTitlesFromConfig);
+  });
+});

test/unit/titles-get-all-print-titles-by-namespace-test.js → test/unit/titles-get-titles-by-namespace-test.js

@@ -1,4 +1,4 @@
-import { getPrintTitlesByNamespace, productConfig } from "../../lib/titles.js";
+import { getTitlesByNamespace, getPrintTitlesByNamespace, productConfig } from "../../lib/titles.js";
 
 const namespaceSafety = [
   { namespace: "dn", text: "DN" },
@@ -9,14 +9,20 @@ const namespaceSafety = [
   { namespace: "gotamedia", text: "Gota Media" },
 ];
 
-describe("getTitlesByNamespace", () => {
+describe("get titles by namespace", () => {
   for (const n of namespaceSafety) {
     describe(n.text, () => {
       it(`should return all titles in namespace: ${n.namespace}`, () => {
-        const titles = getPrintTitlesByNamespace(n.namespace);
+        const titles = getTitlesByNamespace(n.namespace);
         const titlesFromConfig = productConfig[n.namespace].map((pm) => pm.title).filter((t) => t);
         titles.should.eql(titlesFromConfig);
       });
+
+      it(`should return all print titles in namespace: ${n.namespace}`, () => {
+        const titles = getPrintTitlesByNamespace(n.namespace);
+        const titlesFromConfig = productConfig[n.namespace].filter((t) => t.tsCode).map((pm) => pm.title).filter((t) => t);
+        titles.should.eql(titlesFromConfig);
+      });
     });
   }
 });