Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use eslint 9 #43

Merged
merged 36 commits into from
Feb 27, 2025
Merged

Use eslint 9 #43

merged 36 commits into from
Feb 27, 2025

Conversation

markusn
Copy link
Contributor

@markusn markusn commented Feb 7, 2025

2.X introduces eslint 9 which has a different configuration format. It is recommended to read the eslint migration guide.

A major change from eslint 8 is that only one eslint.config.js file will be used, placing a specific configuration file in a folder will not behave in the same
way as in 8 where it would inherit the configuration from files from the root folder, and the new recommendation is to just have one eslint.config.js at the root
of the repository.

The different rule sets have changed name and behaviour:

  • @bonniernews/eslint-config will import configs and apply them to the respective targets
  • @bonniernews/eslint-config/js config for js files
  • @bonniernews/eslint-config/ts config for ts files
  • @bonniernews/eslint-config/jsx config for jsx files
  • @bonniernews/eslint-config/tsx config for tsx files
  • @bonniernews/eslint-config/test config for test files using mocha-cakes-2 and chai

All dependencies have been bumped to the latest versions.

* adapt to new config format
* moved test and react config into default config
* moved typescript-react config into typescript config
* removed `all`, `test`, `react` and `typescript-react` and separate configs
@markusn markusn marked this pull request as ready for review February 11, 2025 15:18
Copy link
Contributor

@kristofferjansson kristofferjansson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, commented on some nitpicks in the README

markusn and others added 3 commits February 20, 2025 09:03
Co-authored-by: Kristoffer Jansson <[email protected]>
Co-authored-by: Kristoffer Jansson <[email protected]>
Co-authored-by: Kristoffer Jansson <[email protected]>
Copy link
Contributor

@MattiasOlla MattiasOlla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiiiiice. Small error in the readme.

@markusn markusn merged commit 7179560 into master Feb 27, 2025
3 checks passed
@markusn markusn deleted the use-eslint-9 branch February 27, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants