-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use eslint 9 #43
Merged
Merged
Use eslint 9 #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* adapt to new config format * moved test and react config into default config * moved typescript-react config into typescript config * removed `all`, `test`, `react` and `typescript-react` and separate configs
bf14c6c
to
b450504
Compare
kristofferjansson
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, commented on some nitpicks in the README
Co-authored-by: Kristoffer Jansson <[email protected]>
Co-authored-by: Kristoffer Jansson <[email protected]>
Co-authored-by: Kristoffer Jansson <[email protected]>
MattiasOlla
approved these changes
Feb 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Niiiiiice. Small error in the readme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.X introduces eslint 9 which has a different configuration format. It is recommended to read the eslint migration guide.
A major change from eslint 8 is that only one
eslint.config.js
file will be used, placing a specific configuration file in a folder will not behave in the sameway as in 8 where it would inherit the configuration from files from the root folder, and the new recommendation is to just have one
eslint.config.js
at the rootof the repository.
The different rule sets have changed name and behaviour:
@bonniernews/eslint-config
will import configs and apply them to the respective targets@bonniernews/eslint-config/js
config for js files@bonniernews/eslint-config/ts
config for ts files@bonniernews/eslint-config/jsx
config for jsx files@bonniernews/eslint-config/tsx
config for tsx files@bonniernews/eslint-config/test
config for test files using mocha-cakes-2 and chaiAll dependencies have been bumped to the latest versions.