js: improve bindings return types

Bonfida · May 30, 2024 · c93754e · c93754e
1 parent aae48f1
commit c93754e
Show file tree

Hide file tree

Showing 11 changed files with 15 additions and 15 deletions.
diff --git a/js/src/bindings/createReverseName.ts b/js/src/bindings/createReverseName.ts
@@ -49,5 +49,5 @@ export const createReverseName = async (
 
   let instructions = [initCentralStateInstruction];
 
-  return [[], instructions];
+  return instructions;
 };
diff --git a/js/src/bindings/createSolRecordInstruction.ts b/js/src/bindings/createSolRecordInstruction.ts
@@ -49,5 +49,5 @@ export const createSolRecordInstruction = async (
     signer,
   );
 
-  return [ix];
+  return ix;
 };
diff --git a/js/src/bindings/createSubdomain.ts b/js/src/bindings/createSubdomain.ts
@@ -51,7 +51,7 @@ export const createSubdomain = async (
   const reverseKey = getReverseKeySync(subdomain, true);
   const info = await connection.getAccountInfo(reverseKey);
   if (!info?.data) {
-    const [, ix_reverse] = await createReverseName(
+    const ix_reverse = await createReverseName(
       pubkey,
       "\0".concat(sub),
       feePayer || owner,
@@ -61,5 +61,5 @@ export const createSubdomain = async (
     ixs.push(...ix_reverse);
   }
 
-  return [[], ixs];
+  return ixs;
 };
diff --git a/js/src/bindings/registerDomainName.ts b/js/src/bindings/registerDomainName.ts
@@ -123,5 +123,5 @@ export const registerDomainName = async (
   );
   ixs.push(ix);
 
-  return [[], ixs];
+  return ixs;
 };
diff --git a/js/src/bindings/registerFavorite.ts b/js/src/bindings/registerFavorite.ts
@@ -18,5 +18,5 @@ export const registerFavorite = (nameAccount: PublicKey, owner: PublicKey) => {
     owner,
     SystemProgram.programId,
   );
-  return [ix];
+  return ix;
 };
diff --git a/js/src/bindings/updateRecordInstruction.ts b/js/src/bindings/updateRecordInstruction.ts
@@ -56,5 +56,5 @@ export const updateRecordInstruction = async (
     owner,
   );
 
-  return [ix];
+  return ix;
 };
diff --git a/js/src/bindings/updateSolRecordInstruction.ts b/js/src/bindings/updateSolRecordInstruction.ts
@@ -53,5 +53,5 @@ export const updateSolRecordInstruction = async (
     signer,
   );
 
-  return [ix];
+  return ix;
 };
diff --git a/js/tests/favorite.test.ts b/js/tests/favorite.test.ts
@@ -71,7 +71,7 @@ test("Register fav", async () => {
   const owner = new PublicKey("Fxuoy3gFjfJALhwkRcuKjRdechcgffUApeYAfMWck6w8");
   const tx = new Transaction();
   const ix = registerFavorite(getDomainKeySync("wallet-guide-3").pubkey, owner);
-  tx.add(...ix);
+  tx.add(ix);
   const { blockhash } = await connection.getLatestBlockhash();
   tx.recentBlockhash = blockhash;
   tx.feePayer = owner;

diff --git a/js/tests/registration.test.ts b/js/tests/registration.test.ts
@@ -23,7 +23,7 @@ const VAULT_OWNER = new PublicKey(
 
 test("Registration", async () => {
   const tx = new Transaction();
-  const [, ix] = await registerDomainName(
+  const ix = await registerDomainName(
     connection,
     randomBytes(10).toString("hex"),
     1_000,
@@ -41,7 +41,7 @@ test("Registration", async () => {
 
 test("Registration with ref", async () => {
   const tx = new Transaction();
-  const [, ix] = await registerDomainName(
+  const ix = await registerDomainName(
     connection,
     randomBytes(10).toString("hex"),
     1_000,
@@ -93,7 +93,7 @@ test("Register with NFT", async () => {
 test("Indempotent ATA creation ref", async () => {
   const tx = new Transaction();
   for (let i = 0; i < 3; i++) {
-    const [, ix] = await registerDomainName(
+    const ix = await registerDomainName(
       connection,
       randomBytes(10).toString("hex"),
       1_000,

diff --git a/js/tests/reverse.test.ts b/js/tests/reverse.test.ts
@@ -14,7 +14,7 @@ test("Create sub", async () => {
   const parent = "bonfida.sol";
 
   const parentOwner = await resolve(connection, parent);
-  const [, ix] = await createSubdomain(
+  const ix = await createSubdomain(
     connection,
     sub + "." + parent,
     parentOwner,

diff --git a/js/tests/sub.test.ts b/js/tests/sub.test.ts
@@ -15,7 +15,7 @@ const connection = new Connection(process.env.RPC_URL!);
 
 test("Create sub", async () => {
   const tx = new Transaction();
-  const [, ix] = await createSubdomain(
+  const ix = await createSubdomain(
     connection,
     randomBytes(10).toString("hex") + ".bonfida",
     new PublicKey("HKKp49qGWXd639QsuH7JiLijfVW5UtCVY4s1n2HANwEA"),
@@ -78,7 +78,7 @@ test("Create sub - Fee payer ", async () => {
   const feePayer = VAULT_OWNER;
 
   const parentOwner = await resolve(connection, parent);
-  const [, ix] = await createSubdomain(
+  const ix = await createSubdomain(
     connection,
     sub + "." + parent,
     parentOwner,