fix: add missing custom error

Bonfida · May 20, 2024 · 61f2077 · 61f2077
1 parent c0a6b4e
commit 61f2077
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 7 deletions.
diff --git a/js/src/bindings.ts b/js/src/bindings.ts
@@ -65,6 +65,7 @@ import { FavouriteDomain, NAME_OFFERS_ID } from "./favorite-domain";
 import {
   AccountDoesNotExistError,
   InvalidDomainError,
+  InvalidParrentError,
   InvalidSubdomainError,
   PythFeedNotFoundError,
   UnsupportedRecordError,
@@ -651,7 +652,7 @@ export const createRecordV2Instruction = (
   }
 
   if (!parent) {
-    throw new Error("Invalid parent");
+    throw new InvalidParrentError("Parent could not be found");
   }
 
   const ix = allocateAndPostRecord(
@@ -743,7 +744,7 @@ export const updateRecordV2Instruction = (
   }
 
   if (!parent) {
-    throw new Error("Invalid parent");
+    throw new InvalidParrentError("Parent could not be found");
   }
 
   const ix = editRecord(
@@ -784,7 +785,7 @@ export const deleteRecordV2 = (
   }
 
   if (!parent) {
-    throw new Error("Invalid parent");
+    throw new InvalidParrentError("Parent could not be found");
   }
 
   const ix = deleteRecord(
@@ -816,7 +817,7 @@ export const validateRecordV2Content = (
   }
 
   if (!parent) {
-    throw new Error("Invalid parent");
+    throw new InvalidParrentError("Parent could not be found");
   }
 
   const ix = validateSolanaSignature(
@@ -849,7 +850,7 @@ export const writRoaRecordV2 = (
   }
 
   if (!parent) {
-    throw new Error("Invalid parent");
+    throw new InvalidParrentError("Parent could not be found");
   }
   const ix = writeRoa(
     payer,
@@ -881,7 +882,7 @@ export const ethValidateRecordV2Content = (
   }
 
   if (!parent) {
-    throw new Error("Invalid parent");
+    throw new InvalidParrentError("Parent could not be found");
   }
 
   const ix = validateEthSignature(

diff --git a/js/src/error.ts b/js/src/error.ts
@@ -31,6 +31,8 @@ export enum ErrorType {
   PythFeedNotFound = "PythFeedNotFound",
   InvalidRoA = "InvalidRoA",
   InvalidPda = "InvalidPda",
+  InvalidParrent = "InvalidParrent",
+  NftRecordNotFound = "NftRecordNotFound",
 }
 
 export class SNSError extends Error {
@@ -237,3 +239,15 @@ export class InvalidPdaError extends SNSError {
     super(ErrorType.InvalidPda, message);
   }
 }
+
+export class InvalidParrentError extends SNSError {
+  constructor(message?: string) {
+    super(ErrorType.InvalidParrent, message);
+  }
+}
+
+export class NftRecordNotFoundError extends SNSError {
+  constructor(message?: string) {
+    super(ErrorType.NftRecordNotFound, message);
+  }
+}
diff --git a/js/src/nft/name-tokenizer.ts b/js/src/nft/name-tokenizer.ts
@@ -1,6 +1,7 @@
 import { deserialize } from "borsh";
 import { Connection, PublicKey } from "@solana/web3.js";
 import { Buffer } from "buffer";
+import { NftRecordNotFoundError } from "../error";
 
 export const NAME_TOKENIZER_ID = new PublicKey(
   "nftD3vbNkNqfj2Sd3HZwbpw4BxxKWr4AjGb9X38JeZk",
@@ -61,7 +62,9 @@ export class NftRecord {
   static async retrieve(connection: Connection, key: PublicKey) {
     const accountInfo = await connection.getAccountInfo(key);
     if (!accountInfo || !accountInfo.data) {
-      throw new Error("NFT record not found");
+      throw new NftRecordNotFoundError(
+        "NFT record not found: " + key.toBase58(),
+      );
     }
     return this.deserialize(accountInfo.data);
   }