feat: nested extra fees #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael1011
force-pushed
the
nested-fees
branch
from
f9d3acc to
843a514
Compare
maybeast
approved these changes
Feb 19, 2025
michael1011
force-pushed
the
nested-fees
branch
from
843a514 to
4ab2254
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow clients to add extra fees to swaps by passing these parameters when creating swaps:
{ ... "extraFees": { "id": "gm", "percentage": 1 } }Those extra fees added can be queried with API keys via
/v2/referral/stats/extra:{ "2025": { "2": { "gm": 13000 } } }Do we want to allow this for every referral?