Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up feed endpoints for use in the frontend, and export open API types as package #157

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Clean up feed endpoints for use in the frontend, and export open API types as package #157

merged 2 commits into from
Nov 21, 2023

Conversation

essential-randomness
Copy link
Collaborator

For Thursday's meeting.

Current limitations:

  1. I have created a package.json to try and export our json openAPI config, which worked fine, but I didn't actually publish the package on NPM.
  2. We probably want a pipeline here that bumps the version of the OpenAPI export when stuff changes and makes a draft PR to boba-frontend to update its required backend version (this will likely require someone to pull the draft PR and make modifications as needed so that everything works). I should write a design doc for this. Force me to, one day.
  3. The Zod types generation was already in, but we should discuss WTF we're doing so everyone can judge whether it's a Ms Boba crime and it needs rectifying before it infects everything.

@essential-randomness essential-randomness marked this pull request as ready for review October 23, 2023 00:08
virtuous-cat
virtuous-cat approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@virtuous-cat virtuous-cat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me! Just one slightly silly note we probably can't actually do anything about.

types/open-api/.config/schemas.hbs Show resolved Hide resolved
Essential Randomness added 2 commits November 20, 2023 15:37
initial cleanup
0d76fa1 
also generate yaml spec

fix some more feed types

add parameters to user feed

add read me

fix accidental change override

move openapi configs to a different folder

move openapi generation to the correct folders

add todo for unzodded queries
fix all merge issues
ddb788b
@essential-randomness essential-randomness merged commit 3a3a596 into main Nov 21, 2023
4 checks passed
@essential-randomness essential-randomness deleted the zod-feed-cleanup branch November 21, 2023 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reptapog Reptapog Reptapog left review comments

@virtuous-cat virtuous-cat virtuous-cat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@essential-randomness @Reptapog @virtuous-cat