-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Nix flake for bobaserver #143
Conversation
flake.nix
Outdated
buildPhase = '' | ||
yarn build | ||
''; | ||
distPhase = ""; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need this since doDist = false;
is set? Will need to check and see.
@@ -1,26 +1,34 @@ | |||
#!/usr/bin/env bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may be worth exporting this script as a package so we can consume it more easily on the server. This would mean the script gets built with psql and want dependencies included.
writeShellApplication
would be the tool of choice for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't psql be the same version as the postgres running on the backend?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes and it will be since we'll set .follows for the flake input.
be2fa0d
to
5f4ba54
Compare
5f4ba54
to
cc06956
Compare
No description provided.