Let users w/ mod permissions hard delete threads

[nrdbstrd]

• Wrote SQL query to delete threads & references to it from database
• Wrote DELETE endpoint for API
• Wrote tests for endpoint
  • currently passes all except for 'thread already deleted test;' the endpoint works correctly, but site now returns a different response than when I originally wrote tests.

[essential-randomness]

are_you_winning_son.png (pls revert :P)

[essential-randomness]

this should also be reverted, and hopefully small spurious changes like these won't happen again once we get our linting sorted

[essential-randomness]

I would write a guard here to check if we're running in a development environment as part of this PR, just so that you can make it actually throw an Error by default. The risk being that we forget you haven't implemented the check, we accidentally do a release, then anyone can delete threads via API.

I think this should be as easy as doing:

router.delete(
  "/:thread_id",
  ensureLoggedIn,
  ensureThreadAccess,
  (_, _, next) => {
     if (process.env. NODE_ENV === "development" || process.env.NODE_ENV === "test") {
        next()
     }
     throw new Api500Error("this function is not available in production");
  },
  async (req, res) => {
  // existing code

....or something like that! Let me know if it doesn't work for any reason, haven't done this before.

Also feel free to put this somewhere so we can reuse it, if you find (or can create) a nice place!

[essential-randomness]

This makes sense, but since we're at it we could split these more just so it's easier to read (and can be reused). I think what would make sense is:

1. delete tags
2. delete comments
3. delete posts
4. delete thread

Feel free to just add it as a TODO!

[essential-randomness]

Also, you're missing index tags I think

[essential-randomness]

This test is failing right now: https://app.circleci.com/pipelines/github/BobaBoard/boba-backend/686/workflows/f8364f0e-c2e5-4564-8ad2-1e5e607747e5/jobs/1153

Feel free to comment it out and add it at the next pass. We probably can get this info as part of checking if the user has permissions for deleting the thread, so no point doing it now.

[essential-randomness]

I don't think you need this. Crossing fingers you should just be able to use any thread that already exists and the test DB setup will automatically rollback your query at the end of your tests (but let me know if this doesn't happen, cause that logic is a bit finicky sometimes). Mostly, adding a new thread will cause a lot of tests to fail cause they rely on how many posts we have in the DB.

(Yes, there's some bad practices at play here....)

I'm also fine with keeping it, but you'll have to fix the tests

[essential-randomness]

You want to use pool.tx here (see:

boba-backend/server/boards/queries.ts

Line 201 in a7069e9

.tx("update-descriptions", async (transaction) => {

)

The reason is that if the query fails midway (e.g. could delete all the tags, but failed on the comments), you want the whole thing to deletion to rollback and the db to be restored to the original state.

See documentation too: https://github.com/vitaly-t/pg-promise#transactions

[essential-randomness]

See my comment at the end on the file. We may or may not want this. I'm inclined to trying to just delete existing ones for now, and then only do this if the db stuff I hacked in (which automatically restores DB state between tests) yells at us later.