Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PW_SID:933394] [BlueZ,v2] btdev: Broadcast EXT_ADV packets based on its interval #2672

Open
wants to merge 2 commits into
base: workflow
Choose a base branch
from

Conversation

BluezTestBot
Copy link
Owner

From: Arkadiusz Bokowy [email protected]

Real BLE devices transmit LE advertisement report packages in given
intervals (typically in range between 20 ms and 10.24 s). With current
kernel module Bluetooth stack implementation it is possible that the
first LE meta packet just after enabling scanning will be lost. It is
not an issue for real devices, because more advertisement reports will
be delivered later (in given interval time).

This patch changes optimistic implementation of sending only one LE
meta packets just after enabling scanning to sending LE meta packets
every minimal interval thus emulating what a real controller would do
and will work around the issue of dropping the very first LE meta packet
by the kernel.

emulator/btdev.c | 103 +++++++++++++++++------------------------------
1 file changed, 37 insertions(+), 66 deletions(-)

tedd-an and others added 2 commits February 12, 2025 21:36
This patch adds workflow files for ci:

[sync.yml]
  - runs every 30 mins.
  - sync repo with upstream repo and rebase workflow branch to tip of
    master.
  - creates PR after reading patches from patchwork.kernel.org

[ci.yml]
  - Tests the following checks:
    - checkpatch
    - gitlint
    - make
    - make check

[code_scan.yml]
    - Static code checker: Coverity and Clang
    - Coverity: Submit the result to the coverity website
    - Clang Code Scan: Send email with result file to the internal team

To simplify the history, new change will amend to this patch without
creating new patch.
Real BLE devices transmit LE advertisement report packages in given
intervals (typically in range between 20 ms and 10.24 s). With current
kernel module Bluetooth stack implementation it is possible that the
first LE meta packet just after enabling scanning will be lost. It is
not an issue for real devices, because more advertisement reports will
be delivered later (in given interval time).

This patch changes optimistic implementation of sending only one LE
meta packets just after enabling scanning to sending LE meta packets
every minimal interval thus emulating what a real controller would do
and will work around the issue of dropping the very first LE meta packet
by the kernel.
@BluezTestBot
Copy link
Owner Author

CheckPatch
Desc: Run checkpatch.pl script
Duration: 0.29 seconds
Result: PENDING

@BluezTestBot
Copy link
Owner Author

GitLint
Desc: Run gitlint
Duration: 0.17 seconds
Result: PENDING

@BluezTestBot
Copy link
Owner Author

BuildEll
Desc: Build and Install ELL
Duration: 20.60 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

BluezMake
Desc: Build BlueZ
Duration: 1550.74 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

MakeCheck
Desc: Run Bluez Make Check
Duration: 13.61 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

MakeDistcheck
Desc: Run Bluez Make Distcheck
Duration: 159.60 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

CheckValgrind
Desc: Run Bluez Make Check with Valgrind
Duration: 215.43 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

CheckSmatch
Desc: Run smatch tool with source
Duration: 285.01 seconds
Result: WARNING
Output:

emulator/btdev.c:450:29: warning: Variable length array is used.

@BluezTestBot
Copy link
Owner Author

bluezmakeextell
Desc: Build Bluez with External ELL
Duration: 98.44 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

IncrementalBuild
Desc: Incremental build with the patches in the series
Duration: 0.33 seconds
Result: PENDING

@BluezTestBot
Copy link
Owner Author

ScanBuild
Desc: Run Scan Build
Duration: 871.70 seconds
Result: PASS

@github-actions github-actions bot force-pushed the workflow branch 5 times, most recently from 8a2a355 to 32dfcd7 Compare February 19, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants