Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PW_SID:929013] [BlueZ,v2,1/2] audio: actually try to enable MTU auto-tuning #2644

Open
wants to merge 3 commits into
base: workflow
Choose a base branch
from

Conversation

BluezTestBot
Copy link
Owner

A "0" for the input MTU passed to the underlying socket is supposed to
indicate that its value should be determined by the L2CAP layer.
However, the current code treats a zero imtu just as if there is
nothing to change.

Introduce an additional flag to indicate that the zero imtu is
explicitly requested by the caller for the purpose of auto-tuning.
Otherwise, the similar behavior remains.

Found by Linux Verification Center (linuxtesting.org).

Fixes: ae5be37 ("avdtp: Enable MTU auto tunning")

v1->v2: incorporate error handling in case the kernel still doesn't
support MTU auto-tuning

btio/btio.c | 34 ++++++++++++++++++++++------------
1 file changed, 22 insertions(+), 12 deletions(-)

tedd-an and others added 3 commits January 28, 2025 15:16
This patch adds workflow files for ci:

[sync.yml]
  - runs every 30 mins.
  - sync repo with upstream repo and rebase workflow branch to tip of
    master.
  - creates PR after reading patches from patchwork.kernel.org

[ci.yml]
  - Tests the following checks:
    - checkpatch
    - gitlint
    - make
    - make check

[code_scan.yml]
    - Static code checker: Coverity and Clang
    - Coverity: Submit the result to the coverity website
    - Clang Code Scan: Send email with result file to the internal team

To simplify the history, new change will amend to this patch without
creating new patch.
A "0" for the input MTU passed to the underlying socket is supposed to
indicate that its value should be determined by the L2CAP layer.
However, the current code treats a zero imtu just as if there is
nothing to change.

Introduce an additional flag to indicate that the zero imtu is
explicitly requested by the caller for the purpose of auto-tuning.
Otherwise, the similar behavior remains.

Found by Linux Verification Center (linuxtesting.org).

Fixes: ae5be37 ("avdtp: Enable MTU auto tunning")
L2CAP frames are lost while utilizing some exotic A2DP transports
usually coming up with weird custom MTU sizes so take advantage of
auto-tuning it for such cases.

Found by Linux Verification Center (linuxtesting.org).

Fixes: bluez#1080
@BluezTestBot
Copy link
Owner Author

CheckPatch
Desc: Run checkpatch.pl script
Duration: 0.20 seconds
Result: PENDING

@BluezTestBot
Copy link
Owner Author

GitLint
Desc: Run gitlint
Duration: 0.23 seconds
Result: PENDING

@BluezTestBot
Copy link
Owner Author

BuildEll
Desc: Build and Install ELL
Duration: 20.68 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

BluezMake
Desc: Build BlueZ
Duration: 1518.75 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

MakeCheck
Desc: Run Bluez Make Check
Duration: 13.65 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

MakeDistcheck
Desc: Run Bluez Make Distcheck
Duration: 161.86 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

CheckValgrind
Desc: Run Bluez Make Check with Valgrind
Duration: 215.75 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

CheckSmatch
Desc: Run smatch tool with source
Duration: 272.39 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

bluezmakeextell
Desc: Build Bluez with External ELL
Duration: 98.65 seconds
Result: PASS

@BluezTestBot
Copy link
Owner Author

IncrementalBuild
Desc: Incremental build with the patches in the series
Duration: 0.30 seconds
Result: PENDING

@BluezTestBot
Copy link
Owner Author

ScanBuild
Desc: Run Scan Build
Duration: 866.92 seconds
Result: PASS

@github-actions github-actions bot force-pushed the workflow branch 6 times, most recently from 7a793c4 to bef7d63 Compare February 4, 2025 23:14
@github-actions github-actions bot force-pushed the workflow branch 6 times, most recently from d2e8011 to 243e77e Compare February 14, 2025 16:18
@github-actions github-actions bot force-pushed the workflow branch 2 times, most recently from 8a2a355 to 32dfcd7 Compare February 19, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants