Fixing dtype issues in network.get #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joni-herttuainen
commented
Jun 8, 2023
There was a problem hiding this comment.
@GianlucaFicarelli : Can you take a quick look and provide your opinion to the questions I raised.
No need to do a full review or spend too much time on this. Just initial thoughts is fine.
Also: I couldn't come up with new scenarios we should be testing for. If anything comes to mind, let me know.
joni-herttuainen
force-pushed
the
nsetm-2186
branch
from
0b33314
to
a31aee6
Compare
joni-herttuainen
requested review from
mgeplf and
edasubert
and removed request for
edasubert and
mgeplf
joni-herttuainen
force-pushed
the
nsetm-2186
branch
from
4fb38f0
to
5a77746
Compare
Codecov Report
@@ Coverage Diff @@
## master #217 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 29 29
Lines 2186 2168 -18
=========================================
- Hits 2186 2168 -18
Flags with carried forward coverage won't be shown. Click here to find out more.
|
joni-herttuainen
force-pushed
the
nsetm-2186
branch
from
5a77746
to
5c839af
Compare
mgeplf
reviewed
Jul 12, 2023
mgeplf
approved these changes
Oct 16, 2023
This was referenced Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #198 .
Fixes #203 .
Furthermore the following can be closed: