Add Windows wheels. #1365
Draft
Add Windows wheels. #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently rely on two files being present in pre-defined directories: * nrnunits.lib * libpywrapper.so (or similar) These are searched for in: * CMake's binary directory for NMODL * CMake's install directory for NMODL * The environment variable `NMODLHOME` Leading to some acrobatics to always set NMODLHOME correctly. This PR attempts to also find the above files relative to the NMODL executable, in the hope that some use cases of NMODLHOME can be removed.
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Jul 22, 2024
This comment has been minimized.
This comment has been minimized.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1365 +/- ##
==========================================
+ Coverage 86.82% 86.90% +0.07%
==========================================
Files 179 179
Lines 13684 13667 -17
==========================================
- Hits 11881 11877 -4
+ Misses 1803 1790 -13 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
bbpadministrator
pushed a commit
to BlueBrain/nmodl-references
that referenced
this pull request
Jul 22, 2024
This comment has been minimized.
This comment has been minimized.
…l-home' into matz-e/WinWheel
This comment has been minimized.
This comment has been minimized.
|
Logfiles from GitLab pipeline #223480 (:white_check_mark:) have been uploaded here! Status and direct links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.