Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Homogenize finding our components. #1336

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Homogenize finding our components. #1336

wants to merge 11 commits into from

Commits on Jul 11, 2024

  1. Homogenize finding our components. 

    We currently rely on two files being present in pre-defined directories:

* nrnunits.lib
* libpywrapper.so (or similar)

These are searched for in:

* CMake's binary directory for NMODL
* CMake's install directory for NMODL
* The environment variable `NMODLHOME`

Leading to some acrobatics to always set NMODLHOME correctly.  This PR
attempts to also find the above files relative to the NMODL executable,
in the hope that some use cases of NMODLHOME can be removed.
    @matz-e
    matz-e committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    91cb9e0 View commit details
    Browse the repository at this point in the history

  2. ❄️

    @matz-e
    matz-e committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    c6dbd20 View commit details
    Browse the repository at this point in the history

  3. Shrink API.

    @matz-e
    matz-e committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    3fafed8 View commit details
    Browse the repository at this point in the history

  4. Attempt to be more ARGV independent.

    @matz-e
    matz-e committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    6441841 View commit details
    Browse the repository at this point in the history

  5. Fixeth for the AppleOS

    @matz-e
    matz-e committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    9499115 View commit details
    Browse the repository at this point in the history

  6. More AppleOS fixes.

    @matz-e
    matz-e committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    f4863e4 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Fix Windows after local reproducer.

    @matz-e
    matz-e committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    c765a3a View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. Merge branch 'master' into attempted-defenestration-of-nmodl-home

    @matz-e
    matz-e authored Jul 22, 2024
    Configuration menu
    Copy the full SHA
    d97d88c View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Fix merge.

    @matz-e
    matz-e committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    fab9a4a View commit details
    Browse the repository at this point in the history

  2. Explicit conversion to string.

    @matz-e
    matz-e committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    0200e0f View commit details
    Browse the repository at this point in the history

  3. Forgotten header modifications.

    @matz-e
    matz-e committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    62a5a49 View commit details
    Browse the repository at this point in the history