Improve names.

BlueBrain · Oct 10, 2024 · d88ad52 · d88ad52
1 parent 0d428cf
commit d88ad52
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/src/language/nmodl.yaml b/src/language/nmodl.yaml
@@ -1152,15 +1152,15 @@
                             type: Expression
 
                   - LinEquation:
-                      brief: "TODO"
+                      brief: "One equation in a system of equations tha collectively form a LINEAR block."
                       nmodl: "~ "
                       members:
-                        - left_linxpression:
-                            brief: "TODO"
+                        - lhs:
+                            brief: "Left-hand-side of the equation."
                             type: Expression
                             suffix: {value: " = "}
-                        - linxpression:
-                            brief: "TODO"
+                        - rhs:
+                            brief: "Right-hand-side of the equation."
                             type: Expression
 
                   - FunctionCall:

diff --git a/src/visitors/sympy_replace_solutions_visitor.cpp b/src/visitors/sympy_replace_solutions_visitor.cpp
@@ -226,11 +226,11 @@ void SympyReplaceSolutionsVisitor::visit_diff_eq_expression(ast::DiffEqExpressio
 void SympyReplaceSolutionsVisitor::visit_lin_equation(ast::LinEquation& node) {
     logger->debug("SympyReplaceSolutionsVisitor :: visit {}", to_nmodl(node));
     auto get_lhs = [](const ast::Node& node) -> std::shared_ptr<ast::Expression> {
-        return dynamic_cast<const ast::LinEquation&>(node).get_left_linxpression();
+        return dynamic_cast<const ast::LinEquation&>(node).get_lhs();
     };
 
     auto get_rhs = [](const ast::Node& node) -> std::shared_ptr<ast::Expression> {
-        return dynamic_cast<const ast::LinEquation&>(node).get_left_linxpression();
+        return dynamic_cast<const ast::LinEquation&>(node).get_rhs();
     };
 
     try_replace_tagged_statement(node, get_lhs, get_rhs);

diff --git a/src/visitors/sympy_solver_visitor.cpp b/src/visitors/sympy_solver_visitor.cpp
@@ -577,9 +577,9 @@ void SympySolverVisitor::visit_derivative_block(ast::DerivativeBlock& node) {
 
 void SympySolverVisitor::visit_lin_equation(ast::LinEquation& node) {
     check_expr_statements_in_same_block();
-    std::string lin_eq = to_nmodl_for_sympy(*node.get_left_linxpression());
+    std::string lin_eq = to_nmodl_for_sympy(*node.get_lhs());
     lin_eq += " = ";
-    lin_eq += to_nmodl_for_sympy(*node.get_linxpression());
+    lin_eq += to_nmodl_for_sympy(*node.get_rhs());
     eq_system.push_back(lin_eq);
     expression_statements.insert(current_expression_statement);
     last_expression_statement = current_expression_statement;