Add batch composite sink #4105
Merged
Add batch composite sink #4105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…should still go to the sink
olivergrabinski
force-pushed
the
3890-batch-sink
branch
from
a6dd24d
to
bd6f044
Compare
imsdu
requested changes
Jul 28, 2023
...rc/main/scala/ch/epfl/bluebrain/nexus/delta/plugins/compositeviews/indexing/QueryGraph.scala
Outdated
Show resolved
Hide resolved
...rc/main/scala/ch/epfl/bluebrain/nexus/delta/plugins/compositeviews/indexing/QueryGraph.scala
Outdated
Show resolved
Hide resolved
| } | ||
| case None => | ||
| elements.traverse { | ||
| case e: Elem.SuccessElem[GraphResource] => Task.pure(e.dropped) |
There was a problem hiding this comment.
It should be possible to make this less verbose
There was a problem hiding this comment.
I added a drop function for Elem. In my mind dropping should only affect SuccessElems, and "dropping" Dropped or Failed Elems should not do anything. The functions that we currently have as dropped, failed, and success should perhaps be called asDropped, asFailed, asSuccess, to reflect that it's a deliberate action? But I didn't make this name change because I don't want to modify too many files that are unrelated to this PR
| private def extractGraphResource(gr: GraphResource, fullGraph: Graph) = { | ||
| implicit val api: JsonLdApi = JsonLdJavaApi.lenient | ||
| fullGraph | ||
| .replaceRootNode(iri"${gr.id}/alias") |
There was a problem hiding this comment.
We keep with this ?
We will need to document it properly
There was a problem hiding this comment.
I'm not sure how to avoid it. The name can change but that makes only a minor difference. And yes it would have to be documented
...src/main/scala/ch/epfl/bluebrain/nexus/delta/plugins/compositeviews/BatchCompositeSink.scala
Outdated
Show resolved
Hide resolved
...in/scala/ch/epfl/bluebrain/nexus/delta/plugins/compositeviews/indexing/CompositeSpaces.scala
Outdated
Show resolved
Hide resolved
imsdu
reviewed
Aug 2, 2023
...iews/src/main/scala/ch/epfl/bluebrain/nexus/delta/plugins/compositeviews/CompositeSink.scala
Outdated
Show resolved
Hide resolved
imsdu
requested changes
Aug 2, 2023
...iews/src/main/scala/ch/epfl/bluebrain/nexus/delta/plugins/compositeviews/CompositeSink.scala
Outdated
Show resolved
Hide resolved
...iews/src/main/scala/ch/epfl/bluebrain/nexus/delta/plugins/compositeviews/CompositeSink.scala
Outdated
Show resolved
Hide resolved
...scala/ch/epfl/bluebrain/nexus/delta/plugins/compositeviews/config/CompositeViewsConfig.scala
Outdated
Show resolved
Hide resolved
tests/src/test/resources/kg/views/composite/composite-view-include-context.json
Outdated
Show resolved
Hide resolved
imsdu
reviewed
Aug 3, 2023
...rc/main/scala/ch/epfl/bluebrain/nexus/delta/plugins/compositeviews/indexing/QueryGraph.scala
Outdated
Show resolved
Hide resolved
imsdu
reviewed
Aug 3, 2023
...rc/main/scala/ch/epfl/bluebrain/nexus/delta/plugins/compositeviews/indexing/QueryGraph.scala
Outdated
Show resolved
Hide resolved
imsdu
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new batch composite sink. This sink allows to query the blazegraph common namespace for multiple resources at a time. From the resulting graph, we extract the information about each resource (in Delta), and push it to the target sink.
#3890