Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4912/validation error when updating resources #1532

Merged

Conversation

Dinika
Copy link
Contributor

@Dinika Dinika commented May 1, 2024

Fixes #4912

Adds error details in json
Screenshot from 2024-05-01 17-27-07

At the moment I've not implemented this second part or "icing on the cake" mentioned in the issue mostly because right now I only get the schema https://neuroshapes.org/dash/cellcompositionvolume?rev=122 as a substring of the value error.message returned by nexus. I'm not sure if it's a good idea to parse this string (using regexp) to find the second link that kinda looks like an href and try to resolve it. It sounds flaky to me to do that. I want to discuss if schema.contentUrl.@id can be used instead:

Icing on the cake, presenting a validation specific output that provides links to the relevant schema so the user can navigate to it without losing the vlaidation report currently on screen (e.g. opening a new tab).

How has this been tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

@Dinika Dinika changed the base branch from main to migration-merge May 1, 2024 15:29
@Dinika Dinika requested review from danburonline and bilalesi and removed request for danburonline May 1, 2024 15:35
@bilalesi
Copy link
Contributor

bilalesi commented May 2, 2024

LGTM
regarding this part I want to discuss if schema.contentUrl.@id can be used instead: we may ask delta for help
I will approve and create another PR for this matter if they confirm

@Dinika Dinika merged commit 2e63dfe into migration-merge May 2, 2024
@Dinika Dinika deleted the 4912/validation-error-when-updating-resources branch May 2, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants