Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple file download in resource container #1526

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

Dinika
Copy link
Contributor

@Dinika Dinika commented Mar 20, 2024

Fixes Bug reported by @NicoRicardi here

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

@Dinika Dinika force-pushed the fix-multiple-file-download-in-resource-container branch from fa70e7f to a1f524e Compare March 20, 2024 09:29
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 48.03%. Comparing base (70bca66) to head (a1f524e).

Files Patch % Lines
src/shared/components/Preview/Preview.tsx 14.28% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1526      +/-   ##
===========================================
- Coverage    48.06%   48.03%   -0.04%     
===========================================
  Files          251      251              
  Lines        11561    11565       +4     
  Branches      2709     2709              
===========================================
- Hits          5557     5555       -2     
- Misses        5970     5975       +5     
- Partials        34       35       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dinika Dinika merged commit e18e42f into develop Mar 20, 2024
1 check passed
@Dinika Dinika deleted the fix-multiple-file-download-in-resource-container branch March 20, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants