Develop #1480
Merged
Develop #1480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Very lean and simple.
… chore/add-vs-debugger # Conflicts: # src/shared/containers/ResourceViewActionsContainer.tsx
Two type errors are currently still suppressed. I need to fix them. However, the logic works already.
Two remaining.
Still some TODOs left to improve this sub view and its logic.
However, doesn't work now if there are two resource types, such as `ElasticSearchView` and `View`. Need to fix this in the coming commit(s).
Instead of disallowing the starting of all fields with an underscore, I now only allow the topmost fields to not start with an underscore.
Undeprecate other resource types (`schemas`, `views` and `storages`)
…hrough scrolling) Signed-off-by: Dinika Saxena <[email protected]>
One test remaining...
Fixed edge case.
automatically decoded This is a temporary solution until we update react-router to v6 If a nexus id has some encoded chars (like - https://hello.lol/https%3A%2F%2Fencoded.url%2Fwow), history.push pushes this to window.location: https%3A%2F%2Fhello.lol%2Fhttps%3A%2F%2Fencoded.url%2Fwow instead of: https%3A%2F%2Fhello.lol%2Fhttps%253A%252F%252Fencoded.url%252Fwow Using an older version of `history` and forcing all fusion dependencies to use this version is working for now. This solution is taken from remix-run/history#505 (comment) Signed-off-by: Dinika Saxena <[email protected]>
Adjust custom linter logic for code editor
Signed-off-by: Dinika Saxena <[email protected]>
bilalesi
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
How has this been tested?
Types of changes
Checklist: