Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

US 3 // Show resources that are missing paths #1301

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

Dinika
Copy link
Contributor

@Dinika Dinika commented Jun 28, 2023

Fixes #User Story 3

Screenshot from 2023-06-30 14-55-35

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added necessary unit and integration tests.
  • I have added screenshots (if applicable), in the comment section.

@Dinika Dinika force-pushed the us-2/filter-by-projects branch 2 times, most recently from 7cd09eb to 842a3a5 Compare June 30, 2023 10:03
@Dinika Dinika force-pushed the us-3/show-resources-that-are-missing-paths branch 5 times, most recently from 3ff8a6e to dc3dd94 Compare June 30, 2023 14:27
@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2023

Codecov Report

Merging #1301 (7eba61e) into develop (6173894) will increase coverage by 2.36%.
The diff coverage is 73.40%.

❗ Current head 7eba61e differs from pull request most recent head cf520a3. Consider uploading reports for the commit cf520a3 to get more accurate results

@@             Coverage Diff             @@
##           develop    #1301      +/-   ##
===========================================
+ Coverage    44.86%   47.22%   +2.36%     
===========================================
  Files          176      183       +7     
  Lines         7583     7989     +406     
  Branches      1749     1831      +82     
===========================================
+ Hits          3402     3773     +371     
- Misses        4157     4193      +36     
+ Partials        24       23       -1     
Impacted Files Coverage Δ
...anizationProjectsPage/OrganizationProjectsPage.tsx 32.78% <ø> (ø)
src/pages/ProjectsPage/ProjectsPage.tsx 36.08% <ø> (ø)
src/shared/hooks/useAccessDataForTable.tsx 51.18% <ø> (ø)
src/shared/store/reducers/ui-settings.ts 55.55% <0.00%> (-11.12%) ⬇️
...pps/admin/components/Settings/ResolversSubView.tsx 19.44% <0.00%> (ø)
src/shared/molecules/MyDataTable/MyDataTable.tsx 13.72% <6.81%> (-0.57%) ⬇️
src/shared/organisms/DataPanel/DataPanel.tsx 30.30% <48.14%> (+20.26%) ⬆️
src/subapps/dataExplorer/DataExplorer.tsx 68.42% <68.42%> (ø)
src/shared/molecules/AdvancedMode/AdvancedMode.tsx 85.71% <85.71%> (ø)
src/subapps/dataExplorer/DataExplorerTable.tsx 90.00% <90.00%> (ø)
... and 9 more

... and 44 files with indirect coverage changes

Base automatically changed from us-2/filter-by-projects to f-3983/advanced-mode-beta July 4, 2023 07:20
@Dinika Dinika force-pushed the f-3983/advanced-mode-beta branch 2 times, most recently from e23a03b to 9e308c8 Compare July 4, 2023 08:09
@Dinika Dinika force-pushed the us-3/show-resources-that-are-missing-paths branch 4 times, most recently from b59e197 to 6e83f2d Compare July 4, 2023 11:48
@Dinika Dinika force-pushed the f-3983/advanced-mode-beta branch from 9e308c8 to d90904c Compare July 4, 2023 13:12
@Dinika Dinika force-pushed the us-3/show-resources-that-are-missing-paths branch from 6e83f2d to a29cb99 Compare July 4, 2023 13:13
Base automatically changed from f-3983/advanced-mode-beta to develop July 4, 2023 14:16
@Dinika Dinika force-pushed the us-3/show-resources-that-are-missing-paths branch from a29cb99 to cf520a3 Compare July 4, 2023 14:18
@Dinika Dinika merged commit ed5ac4f into develop Jul 4, 2023
1 check passed
@Dinika Dinika deleted the us-3/show-resources-that-are-missing-paths branch July 4, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants