Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added build_resource_from_response method in SPARQLQueryBuilder #341

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Added build_resource_from_response method in SPARQLQueryBuilder #341

merged 1 commit into from
Sep 29, 2023

Conversation

MFSY
Copy link
Collaborator

@MFSY MFSY commented Sep 28, 2023

No description provided.

@ssssarah ssssarah self-requested a review September 29, 2023 12:50
ssssarah
ssssarah approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@ssssarah ssssarah left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find build_resource_from_response from the SparqlQueryBuilder very heavy to read, but this is just a matter of code style and format I guess.

@MFSY MFSY merged commit fc6177c into master Sep 29, 2023
1 check passed
@MFSY MFSY deleted the added_build_resource_from_response branch September 29, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crisely09 crisely09 crisely09 approved these changes

@ssssarah ssssarah ssssarah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MFSY @crisely09 @ssssarah