Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate unit tests to GitHub #175

Open
wants to merge 62 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
62 commits
Select commit Hold shift + click to select a range
3a01907
download neocortex mods from github repo
WeinaJi Jun 3, 2024
de28dde
Add integration unit tests
WeinaJi Jun 3, 2024
46c30e9
install neurodamus with full dependency
WeinaJi Jun 3, 2024
f52b592
set environment vars for all steps
WeinaJi Jun 3, 2024
a553e45
Add neurodamus-models branch
jorblancoa Sep 11, 2024
0df5eba
LIBSONATA_REPORT variable set in github env
jorblancoa Sep 11, 2024
4ddeeca
Get latest tags instead of hardcode them
jorblancoa Sep 11, 2024
fc17666
fixup! Get latest tags instead of hardcode them
jorblancoa Sep 11, 2024
6ce5a57
Add quotes to pip install
jorblancoa Sep 11, 2024
4eae330
Build models
jorblancoa Sep 12, 2024
9956dfb
fixup! Build models
jorblancoa Sep 12, 2024
f563736
Add NEURODAMUS_PYTHON to github env
jorblancoa Sep 12, 2024
5c5a1b3
Comment integration-e2e since uses bb5 circuit
jorblancoa Sep 12, 2024
d6c7735
add local sub circuit fof v5_sonata for Mini5
WeinaJi Sep 19, 2024
d55493e
adapt unit tests using v5_sonata mini5
WeinaJi Sep 19, 2024
4bfb9e0
add missing file
WeinaJi Sep 19, 2024
64f6bad
Add checks for 3.9.* python version
jorblancoa Sep 19, 2024
4f7fe3f
improve subcircuit: rename pop name from external to external_default
WeinaJi Sep 20, 2024
25628bb
v5_gap subcircuit
WeinaJi Sep 20, 2024
0518807
add missing files
WeinaJi Sep 20, 2024
cfd9346
Adapt v5_sonata unit tests to v5_mini circuit
jorblancoa Sep 23, 2024
ea40ce8
Remove 1k_v5_balance and use Mini5 instead
jorblancoa Sep 24, 2024
48c941f
local subcircuit for sscx-v7-plasticity
WeinaJi Sep 24, 2024
2a7ce64
Change output dir
jorblancoa Sep 24, 2024
e2d638b
Add RDMAV_FORK_SAFE=1 for all python versions
jorblancoa Sep 24, 2024
1c79745
Replace bluepysnap with libsonata in the unit test
WeinaJi Sep 24, 2024
6916878
fix flake8
WeinaJi Sep 24, 2024
8ecd69f
Enable debug session
jorblancoa Sep 25, 2024
b71c422
Add 60 min timeout
jorblancoa Sep 25, 2024
f799821
Compare currents from compartments to avoid summation differences dep…
jorblancoa Sep 25, 2024
f0db30d
extract subcircuit for ngv
WeinaJi Sep 25, 2024
11856f0
Update morphologies dir for v5_gapjunctions
jorblancoa Sep 25, 2024
f76c54b
fix test_connection.py for github runners
WeinaJi Sep 25, 2024
27774c8
fix v5_gapjunctions
WeinaJi Sep 25, 2024
6a507f9
roll back neuron version for fast testing
WeinaJi Sep 25, 2024
cb43ccf
Revert "roll back neuron version for fast testing"
WeinaJi Sep 25, 2024
c0c724e
comment out some tests
WeinaJi Sep 25, 2024
26ad2d2
Uncomment the tests
jorblancoa Sep 26, 2024
96cb668
build ngv model for ngv test
WeinaJi Sep 26, 2024
5f505db
correct ngv build
WeinaJi Sep 26, 2024
c96ce57
fix ngv build
WeinaJi Sep 26, 2024
90d6416
enable debug session
WeinaJi Sep 27, 2024
cc97046
Use only cmake build
WeinaJi Sep 27, 2024
df15055
fix example run
WeinaJi Sep 27, 2024
bbe7a51
write PATH to GITHUB_ENV and remove repeated pkg install
WeinaJi Sep 29, 2024
60d8fa8
NEURODAMUS_NCX_V5=ON for neocortex model
WeinaJi Sep 29, 2024
e52fcb3
Fix crash test
jorblancoa Sep 30, 2024
90aaec9
Activate virtual env only once
jorblancoa Sep 30, 2024
0a71f18
fixup! Activate virtual env only once
jorblancoa Sep 30, 2024
8e081f7
Adapt crashmode test
jorblancoa Sep 30, 2024
9d14e52
Separate docs_build
jorblancoa Sep 30, 2024
95f4c92
fixup! Separate docs_build
jorblancoa Sep 30, 2024
058330a
fixup! Separate docs_build
jorblancoa Sep 30, 2024
b92349e
Fix docs warning with latest sphinx
jorblancoa Sep 30, 2024
9497c44
fixup! Fix docs warning with latest sphinx
jorblancoa Sep 30, 2024
a9dce11
fixup! Fix docs warning with latest sphinx
jorblancoa Sep 30, 2024
2ed1be2
fixup! Fix docs warning with latest sphinx
jorblancoa Sep 30, 2024
c4889b5
Fix an issue reading extra properties for cells where there is no syn…
jorblancoa Oct 2, 2024
9998205
remove build docs workflow, enable PR builds on ReadTheDocs side
WeinaJi Oct 2, 2024
dea058f
don't copy circuit data iin test_cli_opts.py
WeinaJi Oct 3, 2024
f85b27a
Use tmp_path fixture instead of creating new tmp files
jorblancoa Oct 9, 2024
533687c
Add flake8 in github actions and fix issues
jorblancoa Oct 10, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/simulation_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,10 @@ jobs:
- name: Install test dependencies
run: |
pip install -r tests/requirements.txt
pip install flake8 flake8-pyproject

- name: Run flake8
run: flake8 .
Comment on lines +240 to +243
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you run flake independently on the sources only with no installation? As in separate job with separate status?

Also, ruff may be a better all-in-one linter.


- name: test-unit
run: |
Expand Down
1 change: 1 addition & 0 deletions tests/integration-e2e/test_reports.py
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ def _create_reports_config(original_config_path: Path, tmp_path: Path) -> tuple[

return str(temp_config_path), str(output_dir)


@pytest.mark.slow
def test_v5_sonata_reports(tmp_path):
import numpy.testing as npt
Expand Down
2 changes: 1 addition & 1 deletion tests/scientific/test_lfp.py
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ def _read_sonata_lfp_file(lfp_file):
return node_ids, data


def _create_lfp_config(original_config_path: Path, lfp_file: Path, tmp_path: Path) -> tuple[Path, Path]:
def _create_lfp_config(original_config_path, lfp_file, tmp_path):
"""
Create a modified lfp configuration file in a temporary directory.
"""
Expand Down
Loading