This repository has been archived by the owner on Mar 20, 2023. It is now read-only.
Replace posix_memalign with std::aligned_alloc #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 16, 2022 16:44
Unfortunately aligned_alloc does not allow aligning buffers that are not a multiple of the alignment. To help with this we allocate slightly larger buffers where necessary.
alexsavulescu
approved these changes
Sep 18, 2022
pramodk
pushed a commit
to neuronsimulator/nrn
that referenced
this pull request
Nov 2, 2022
) * Replace posix_memalign with std::aligned_alloc Unfortunately aligned_alloc does not allow aligning buffers that are not a multiple of the alignment. To help with this, we allocate slightly larger buffers (up to the next multiple of the alignment) where necessary. CoreNEURON Repo SHA: BlueBrain/CoreNeuron@414479d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately aligned_alloc does not allow aligning buffers that are not a multiple of the alignment. To help with this we allocate slightly larger buffers where necessary.
Description
Updates
alloc_memoryandnrn_cacheline_allocto usestd::aligned_allocinstead the POSIX memalign.Fixes (partially) #836
Use certain branches in CI pipelines.
CI_BRANCHES:NEURON_BRANCH=master,NMODL_BRANCH=master,SPACK_BRANCH=develop