Significantly Improve Performance of Early Generators #6017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed updates of speed on every tick
- Speed updates are once every 1024t
- Speed also updates on block update
- Update on block update happens on a deferred tick to make sure calculation is not happening many times with many updates
- Changed data sync to client to be on update, not on every tick
- Added javadocs to a few more methods
- Capability checks now exit when power to be transferred is zero, rather than checking all sides for capabilities
- Lack of calculating rotation on client meant the wheels stuttered when they got synced - Left in print statement was printing on every update - Deferred updates were handling incorrectly, correct comparison is now in place using Long.MAX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves thermoelectric generator performance by a minor amount, but the main meat is the waterwheel rewrite.
Waterwheels have an ~order of magnitude performance increase expected for flowing wheels, or ~50x for completely stationary wheels. This comes mainly from not checking the torque every tick, but instead on update.
Old code: spark profile
New code, running estimate: spark profile
New code, perfectly stationary: spark profile