Further mmap fixes and improvements in preparation for the Python bindings #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanSellner
changed the title
FrancescAlted
approved these changes
May 28, 2024
There was a problem hiding this comment.
This looks good to me. @JanSellner do you think this is ready for a merge, or you prefer some more time for testing?
|
@FrancescAlted Thanks for having a look. I think this is ready for merge. All the Python tests are passing locally and I also build all the Linux wheels that I could build without problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am currently preparing the Python bindings and for this also some minor changes to the C sources are necessary (Python PR: Blosc/python-blosc2#198).