Add functions for c|dparams, storage and io defaults #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, while I am somewhat reluctant to add unnecessary API calls, I'd like to support your efforts on the rust front, so let's do it. Also, for completeness, could you add the corresponding API for |
milesgranger
changed the title
|
Thanks @milesgranger ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there,
While working on the rust bindings to c-blosc2 I currently zero initialize the C|DParams and Storage structs and works I think mostly by accident. I do this because the suggested use of
BLOSC2_STORAGE_DEFAULTSandBLOSC2_C|DPARAMS_DEFAULTSdoesn't work due to a different bug in bindgen.I can understand if you don't want to include this, but it'd help me avoid maintaining a branch for compatibility. :) If you do, I'm happy to add/expand the docs to these functions.