Change blosc2.c:set_values to always call memcpy if BLOSC_STRICT_ALIGN #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems a bit strange to me that this simple PR is the only thing required to make 32-bit ARM tests happy on Ubuntu, but if that is the case, I have nothing against it :-). Thanks @mwhudson ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I have some sympathy with the argument in #550 that all this code depending on unaligned access should go away in favour of letting the compiler put it back when it makes sense, this particular instance of it is all that is making the test suite fail on 32-bit ARM on the current Ubuntu devel series.