Add message about printer settings to PDF failure box #3854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added BL-8775 to get localization of all these error strings into crowdin.
andrew-polk
requested changes
Jul 27, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @hatton)
src/BloomExe/Publish/PDF/MakePdfUsingGeckofxHtmlToPdfProgram.cs, line 145 at r1 (raw file):
// This message string is intentionally separate because it was added after the previous string had already been localized in most languages.
Based on your Flowdock message, this is not true, is it? Even if it was, the addition of "Possibility:" before it would invalidate all the existing translations.
Otherwise, LGTM
|
testing a comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added BL-8775 to get localization of all these error strings into crowdin.
We've never figured out how to cause this to happen, so it can't be tested. So please read extra carefully!
This change is