Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename EnrollmentService to EnterpriseCA #75

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

JonasBK
Copy link
Collaborator

@JonasBK JonasBK commented Oct 4, 2023

Description

Rename EnrollmentService node type to EnterpriseCA.

Motivation and Context

The AD object is called enrollment service but Enterprise CA seems to be the name used everywhere.

How Has This Been Tested?

Ran collection. It worked.

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

I will fix the documentation and jira tickets when the PR is accepted.

@juggernot325 juggernot325 merged commit eabd7e4 into adcs Oct 4, 2023
3 checks passed
@juggernot325 juggernot325 deleted the rename-enrollmentservice branch October 4, 2023 20:17
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants