Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make enterprise domain controllers group spit ou the correct sid #174

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

rvazarkar
Copy link
Contributor

@rvazarkar rvazarkar commented Nov 13, 2024

Description

The enterprise domain controllers group is currently being generated with an invalid object identifier causing it to not merge correctly.

Motivation and Context

https://specterops.atlassian.net/issues/BED-4846

How Has This Been Tested?

Unit testing + testing in local lab

Screenshots (if appropriate):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

@rvazarkar rvazarkar merged commit 812d105 into v4 Nov 15, 2024
3 checks passed
@rvazarkar rvazarkar deleted the BED-4846 branch November 15, 2024 16:52
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants