chore: fix comment #1210
rvazarkarAnnotations
1 error and 13 warnings
|
build
Process completed with exit code 1.
|
|
build
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/setup-dotnet@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
build
ProjectReference 'D:\a\SharpHoundCommon\SharpHoundCommon\src\CommonLib\SharpHoundCommonLib.csproj' was resolved using '.NETFramework,Version=v4.6.2' instead of the project target framework '.NETCoreApp,Version=v7.0'. This project may not be fully compatible with your project.
|
|
build
ProjectReference 'D:\a\SharpHoundCommon\SharpHoundCommon\src\SharpHoundRPC\SharpHoundRPC.csproj' was resolved using '.NETFramework,Version=v4.6.2' instead of the project target framework '.NETCoreApp,Version=v7.0'. This project may not be fully compatible with your project.
|
|
build
ProjectReference 'D:\a\SharpHoundCommon\SharpHoundCommon\src\CommonLib\SharpHoundCommonLib.csproj' was resolved using '.NETFramework,Version=v4.6.2' instead of the project target framework '.NETCoreApp,Version=v7.0'. This project may not be fully compatible with your project.
|
|
build
ProjectReference 'D:\a\SharpHoundCommon\SharpHoundCommon\src\SharpHoundRPC\SharpHoundRPC.csproj' was resolved using '.NETFramework,Version=v4.6.2' instead of the project target framework '.NETCoreApp,Version=v7.0'. This project may not be fully compatible with your project.
|
|
build:
src/CommonLib/LdapConnectionPool.cs#L22
Field 'LdapConnectionPool._semaphore' is never assigned to, and will always have its default value null
|
|
build:
test/unit/AsyncEnumerableTests.cs#L79
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
build:
test/unit/AsyncEnumerableTests.cs#L89
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
build:
test/unit/UserRightsAssignmentProcessorTest.cs#L81
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
build:
test/unit/ComputerSessionProcessorTest.cs#L215
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
build:
test/unit/ComputerSessionProcessorTest.cs#L234
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
build:
test/unit/LocalGroupProcessorTest.cs#L129
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
|
|
build:
test/unit/LdapPropertyTests.cs#L960
This call site is reachable on all platforms. 'SecurityIdentifier' is only supported on: 'windows'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1416)
|