BED-4599 configurable collection values #81
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to configure various values related to collecting data from Azure. These configuration options are not required to be set in the config file and will use a reasonable default if not set. Allowing these values to be easily configured can help to improve collection times or troubleshoot issues with collection.
The newly added options are:
batchSize
maxConnsPerHost
maxIdleConnsPerHost
streamCount
To configure them, simply add a new attribute to the
config.json
file with one of the names above. Here's an example:Also, the default values for each of these values have been adjusted to hopefully give better performance. Testing has shown that these new defaults provide better collection times, less timeouts, and better memory management in large environments.
Lastly, the new configuration options have built-in sanity checks to prevent setting to harmful values. If the option is found to be set outside of the defined bounds it will revert to the default value.