-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove empty fields from output #67
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the specific testing comment, do we have any other details on how this was tested against BHCE/BHE with datasets and whether the outcome was in line with v2.1.6?
Yes, a collection with this changeset was run against a remote BHE instance and local BHE/BHCE instances successfully without complication. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a couple of places in the json.RawMessage
s where there's a mix of tabs and spaces used for indentation. It would be nice to format those for consistency, but there's no practical problems here. Tests are very detailed and make a lot of sense, I don't see any obvious gaps here so I say ship it!
omitempty
attributejson.RawMessage
such that thejson.RawMessage
value is also pruned of "empty" fieldsOutput size comparison by kind
Output size comparison by aggregate collection