fix: load config before initializing logger #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superlinkx
reviewed
Dec 6, 2023
Co-authored-by: Alyx Holms <[email protected]>
computator
force-pushed
the
svc_verbosity
branch
from
93d2ab1
to
8a60edd
Compare
superlinkx
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Looks good to me, would love for @ddlees to give it a quick once over in case I'm missing something subtle. Good work!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue from BED-3824 where AzureHound was not respecting the log verbosity setting while running as a windows service.
Previously the logger was being initialized before the config file was loaded so the logger was being set to the default verbosity value. This was being done for the service because if the config was loaded before initializing the logger, the init code would panic due to verbosity being a float64 but being cast as an int.