Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enhance bhe logging to enhance troubleshooting #45

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Conversation

ddlees
Copy link
Contributor

@ddlees ddlees commented Aug 22, 2023

  • encountering an unrecoverable error during ingest AzureHound will log something in form of ending current ingest job due to unrecoverable error while requesting <bheIngestUrl> error=<Error>
  • bhe retry logic includes 503s
  • max retries for ingest batch having been reached AzureHound will log exceeded max retry limit for ingest batch, proceeding with next batch...
  • ending a task will either log Collection completed successfully id=<Job ID> duration=<Duration> or Collection completed with errors during ingest id=<Job ID> duration=<Duration>
  • ingestion appropriately exits when encountering an unrecoverable error

@elikmiller
Copy link
Collaborator

The changes seem sane to me - giving this my approval

@ddlees ddlees merged commit 24fc022 into main Aug 22, 2023
9 checks passed
@ddlees ddlees deleted the BED-3634 branch August 22, 2023 18:45
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants