Added support for using System Assigned Managed Identities on Azure #37
+151
−92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng on Azure workloads.
…not present in the response.
|
Hey @0xffhh and @irshadaj , I would really like to get this PR tested and merged. If I need to help test I'm good with that, or if I need to adopt it that is fine too, but I don't want to step on @0xffhh 's toes. What can I do to move this forward. I like what @0xffhh did, and I'm setting up some automatted installation scripts and this PR would be amazingly helpful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System assigned managed identities are a convenient way to authenticate on Azure workloads.
Added a new command line argument and supporting code to support this type of authentication, on top of the existing authentication forms.
I did some basic testing and it works in my test environment. However, since I don't have proper unittests and integration tests available, I cant do a full run. Any support with that is appreciated to improve this new feature.
Also would appreciate a thorough review + testing from someone with more experience with the codebase before merging.
Running
on a Azure Windows VM which has a system assigned managed identity, will run AzureHound and generate a valid output file.
Edit:
Found an issue when running from a docker container. Please hold off the merge for now until resolved.
Edit2:
Fixed the issue when running in a docker container.