Small fixes #1578
Open
Small fixes #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Syncing from original.
See Blood-Asp#1555 These gems could be from small ores.
See Blood-Asp#1556 - most (or maybe all) GT-specific circuits are already blacklisted, and I don't know of any reason to insist on unifying circuits, but this had a weird side effect described in that bug related to looking up recipes for HV-tier circuits.
|
Implemented #1553 |
Possible by using a GregTech sensor kit on a muffler hatch
|
Implemented #1554 |
|
For 1553, just take the existing code from the GTNH repo. It’s much cleaner. |
at draknyte1's suggestion - apparently already had a cleaner version of the auto-output functionality.
|
Let me know when this is done and I’ll approve. |
|
Chemical formula subscripts inspired by GTNewHorizons/GT5-Unofficial#38 , but hopefully my version is cleaner than that attempt. There might already be something similar in GT++ (in code from before it went private), but I didn't know where to look. Edit: actually, I found the similar function in GT++ before the commit below, it helped inspire me. |
Using Apache Commons Lang.
Copied from GTNH
|
Added a copy of GTNewHorizons/GT5-Unofficial#331 for inclusion in main fork. |
|
@draknyte1 I think this is basically done. If I think of more "small fixes" or you want to list some changes from GTNH to carry over, I can make a new PR for those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request for fixes that seemed too small for separate pull requests. These can be evaluated and approved separately and manually added to the base if desired.
Details will mostly be in the commit messages, though for one I forgot to mention issue #1324