Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Target for generating PDF #145

Merged
merged 1 commit into from
May 18, 2023
Merged

Target for generating PDF #145

merged 1 commit into from
May 18, 2023

Conversation

roconnor-blockstream
Copy link
Collaborator

Texmacs does not make this easy.

Related to #141.

@roconnor-blockstream roconnor-blockstream mentioned this pull request May 17, 2023
Open
@apoelstra
Copy link
Contributor

apoelstra commented May 18, 2023 •
edited
Loading

I have a mild preference for using mxDerivation so that I have the overrideDerivation attribute, which I use to add extra metadata to my derivations. But this is fine. overrideAttrs works.

apoelstra
apoelstra approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a365c82

@roconnor-blockstream
Copy link
Collaborator Author

P.S. It isn't mkDerivation that adds overrideDerivation, it is callPackage that does. runCommand actually uses mkDerivation. mkDerivation does add overrideAttrs which is the new-and-improved version of overrideDerivation.

@roconnor-blockstream roconnor-blockstream merged commit a365c82 into master May 18, 2023
@roconnor-blockstream roconnor-blockstream deleted the mk-pdf branch May 18, 2023 14:52
apoelstra added a commit to apoelstra/local-nix-ci that referenced this pull request Jul 14, 2023
@apoelstra
checkpoint commit
d5c8cb1 
Switched from overrideDerivation to overrideAttrs because
overrideDerivation was not working on Russell's new PDF derivation --
see BlockstreamResearch/simplicity#145

Russell explained on Rocket that overrideDerivation is "old school"
and soft-deprecated and that overrideAttrs is to be prefered. See
https://nixos.org/manual/nixpkgs/stable/#sec-pkg-overrideDerivation
(It references "the overrideAttrs documentation". To find this, scroll
up.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoelstra apoelstra apoelstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roconnor-blockstream @apoelstra