Skip to content

Commit

Permalink
Merge #84: Fix bitcoind tests
Browse files Browse the repository at this point in the history
759a534 test: Build integration tests in CI (Christian Lewe)
e0093b2 feat: Build elements from dev shell (Christian Lewe)
3a9bcee chore: Remove superfluous files (Christian Lewe)
f9a1a7d chore: Update elementsd nix shell (Christian Lewe)
b8dcb01 fix: Make bitcoind-tests compile (Christian Lewe)

Pull request description:

  Revive the bitcoind-tests sub crate for integration tests. Make it compile and check that it builds in CI to prevent future breaks. Integrate elementsd derivation in the nix flake.

  This derivation takes a long time to build because it compiles elementsd from scratch. Once the derivation is built, it is cached, but I don't think we can use it for CI. Until we have some sort of caching, we have to run the integration tests locally. In any case, there is barely any integration test at the moment. I will add more tests once I can generate the witness data for them.

ACKs for top commit:
  apoelstra:
    ACK 759a534 successfully ran local tests; just tested that the ordinary crate stuff works, did not test the flake

Tree-SHA512: 81c67be8c1b909b7f1672697a090d4c01fb62ae9cd8009859f2a8d81c5808958cf3796f3b75b03fc8474ef5bbfed119b892fed210287d1e2d4afe82909c1ebdb
  • Loading branch information
apoelstra committed Sep 2, 2024
2 parents 10429c3 + 759a534 commit c75cd2a
Show file tree
Hide file tree
Showing 11 changed files with 221 additions and 155 deletions.
20 changes: 20 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -78,3 +78,23 @@ jobs:
- name: Run each fuzzer for 30s
run: |
nix develop .#fuzz --command bash -c "just check_fuzz"
build-integration:
name: Build - integration tests
runs-on: ubuntu-latest

steps:
- name: Checkout
uses: actions/checkout@v3

- name: Install nix
uses: cachix/install-nix-action@v24
with:
github_access_token: ${{ secrets.GITHUB_TOKEN }}

- name: Enable Rust cache
uses: Swatinem/rust-cache@v2

- name: Build each integration test
run: |
nix develop .#ci --command bash -c "just build_integration"
2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,4 @@ getrandom = { version = "0.2", features = ["js"] }

[workspace]
members = ["codegen"]
exclude = ["fuzz"]
exclude = ["fuzz", "bitcoind-tests"]
1 change: 0 additions & 1 deletion bitcoind-tests/.gitignore

This file was deleted.

Loading

0 comments on commit c75cd2a

Please sign in to comment.