-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Fix check of __builtin functions #247
base: master
Are you sure you want to change the base?
build: Fix check of __builtin functions #247
Commits on Mar 16, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 1a6be57 - Browse repository at this point
Copy the full SHA 1a6be57View commit details -
Configuration menu - View commit details
-
Copy full SHA for cca8cbb - Browse repository at this point
Copy the full SHA cca8cbbView commit details
Commits on Mar 17, 2022
-
configure: Don't abort if the compiler does not define __STDC__
This removes a check for $ac_cv_prog_cc_c89 which is set by AC_PROG_CC if defined(__STDC__) in the preprocessor. (Standard compliant compilers are supposed to define __STDC__ to 1 but the value is actually not checked here.) Unfortunately, MSVC doesn't define it, so configure fails for MSVC. This check is not very useful in practice. Over 30 years after C89 has been released, there are no C compilers out there that are not sufficiently compliant with C89 for the project. The only practically relevant case was that the check rejected C++ compilers. A different method to reject C++ compilers will be introduced in a later commit.
Configuration menu - View commit details
-
Copy full SHA for 1cc0941 - Browse repository at this point
Copy the full SHA 1cc0941View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b4f3d0 - Browse repository at this point
Copy the full SHA 3b4f3d0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 09f3d71 - Browse repository at this point
Copy the full SHA 09f3d71View commit details
Commits on Mar 28, 2022
-
Save negations in var-time group addition
- Updated _gej_add_var, _gej_add_ge_var, _gej_add_zinv_var - 2 fewer _fe_negate in each method - Updated operation counts and standardize layout - Added internal benchmark for _gej_add_zinv_var - Update sage files (fixed by Tim Ruffing)
Configuration menu - View commit details
-
Copy full SHA for 2f984ff - Browse repository at this point
Copy the full SHA 2f984ffView commit details
Commits on Apr 15, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 7efc983 - Browse repository at this point
Copy the full SHA 7efc983View commit details
Commits on Apr 16, 2022
-
Merge bitcoin-core/secp256k1#1056: Save negations in var-time group a…
…ddition 2f984ff Save negations in var-time group addition (Peter Dettman) Pull request description: - Updated _gej_add_var, _gej_add_ge_var, _gej_add_zinv_var - 2 fewer _fe_negate in each method - Updated operation counts and standardize layout - Added internal benchmark for _gej_add_zinv_var benchmark_internal shows about 2% speedup in each method as a result (64bit). ACKs for top commit: real-or-random: ACK 2f984ff jonasnick: ACK 2f984ff Tree-SHA512: 01366fa23c83a8dd37c9a0a24e0acc53ce38a201607fe4da6672ea5618d82c62d1299f0e0aa50317883821539af739ea52b6561faff230c148e6fdc5bc5af30b
Configuration menu - View commit details
-
Copy full SHA for 8b013fc - Browse repository at this point
Copy the full SHA 8b013fcView commit details -
Merge bitcoin-core/secp256k1#1104: Fix the false positive of `SECP_64…
…BIT_ASM_CHECK` 7efc983 Fix the false positive of `SECP_64BIT_ASM_CHECK` (Sprite) Pull request description: I'm trying to compile this project for RISC-V architecture, and I encountered errors: ``` src/field_5x52_asm_impl.h:28:1: error: unknown register name '%r15' in 'asm' 28 | __asm__ __volatile__( | ^ src/field_5x52_asm_impl.h:28:1: error: unknown register name '%r14' in 'asm' src/field_5x52_asm_impl.h:28:1: error: unknown register name '%r13' in 'asm' src/field_5x52_asm_impl.h:28:1: error: unknown register name '%r12' in 'asm' src/field_5x52_asm_impl.h:28:1: error: unknown register name '%r11' in 'asm' src/field_5x52_asm_impl.h:28:1: error: unknown register name '%r10' in 'asm' src/field_5x52_asm_impl.h:28:1: error: unknown register name '%r9' in 'asm' src/field_5x52_asm_impl.h:28:1: error: unknown register name '%r8' in 'asm' src/field_5x52_asm_impl.h:28:1: error: unknown register name '%rdx' in 'asm' src/field_5x52_asm_impl.h:28:1: error: unknown register name '%rcx' in 'asm' src/field_5x52_asm_impl.h:28:1: error: unknown register name '%rax' in 'asm' src/field_5x52_asm_impl.h:28:1: error: output number 0 not directly addressable src/field_5x52_asm_impl.h: In function 'secp256k1_fe_sqr': src/field_5x52_asm_impl.h:298:1: error: unknown register name '%r15' in 'asm' 298 | __asm__ __volatile__( | ^ src/field_5x52_asm_impl.h:298:1: error: unknown register name '%r14' in 'asm' src/field_5x52_asm_impl.h:298:1: error: unknown register name '%r13' in 'asm' src/field_5x52_asm_impl.h:298:1: error: unknown register name '%r12' in 'asm' src/field_5x52_asm_impl.h:298:1: error: unknown register name '%r11' in 'asm' src/field_5x52_asm_impl.h:298:1: error: unknown register name '%r10' in 'asm' src/field_5x52_asm_impl.h:298:1: error: unknown register name '%r9' in 'asm' src/field_5x52_asm_impl.h:298:1: error: unknown register name '%r8' in 'asm' src/field_5x52_asm_impl.h:298:1: error: unknown register name '%rdx' in 'asm' src/field_5x52_asm_impl.h:298:1: error: unknown register name '%rcx' in 'asm' src/field_5x52_asm_impl.h:298:1: error: unknown register name '%rbx' in 'asm' src/field_5x52_asm_impl.h:298:1: error: unknown register name '%rax' in 'asm' src/field_5x52_asm_impl.h:298:1: error: output number 0 not directly addressable ``` After further investigation I found that for RISC-V, macro `USE_ASM_X86_64` was defined unexpectedly, and `checking for x86_64 assembly availability... yes` appeared in the compilation log file, which means `SECP_64BIT_ASM_CHECK` was not working as expected. For unknown reasons, `AC_COMPILE_IFELSE` does not check if `__asm__` can be compiled, and an example can verify this point: ```m4 AC_DEFUN([SECP_64BIT_ASM_CHECK],[ AC_MSG_CHECKING(for x86_64 assembly availability) AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[ #include <stdint.h>]],[[ __asm__ __volatile__("this is obviously wrong"); ]])],[has_64bit_asm=yes],[has_64bit_asm=no]) AC_MSG_RESULT([$has_64bit_asm]) ]) ``` It always gives results: `checking for x86_64 assembly availability... yes` After testing, replacing `AC_COMPILE_IFELSE` with `AC_LINK_IFELSE` can correctly check if `__asm__` can be compiled and make the project able to compile for RISC-V. ACKs for top commit: real-or-random: ACK 7efc983 Tree-SHA512: 7318dd42004b2930cfcd6541c5a9ce0aa186e2179a668b76089a908bea8d9f70fcfdb264512f971e395a3ce9dc7f9ca24c8f3d46175cad2972a2d713f518ed85
Configuration menu - View commit details
-
Copy full SHA for 485f608 - Browse repository at this point
Copy the full SHA 485f608View commit details
Commits on May 4, 2022
-
abi: Don't export symbols in static Windows libraries
libtool takes care of building both object versions, we just need to pick the right one to export symbols.
Configuration menu - View commit details
-
Copy full SHA for 6f6cab9 - Browse repository at this point
Copy the full SHA 6f6cab9View commit details
Commits on May 19, 2022
-
Merge bitcoin-core/secp256k1#1105: Don't export symbols in static lib…
…raries 6f6cab9 abi: Don't export symbols in static Windows libraries (Cory Fields) Pull request description: For context, Bitcoin Core has recently merged [libbitcoin-kernel](bitcoin/bitcoin#24322), a small library that intends to eventually minimally encompass Core's validation engine. This kernel lib includes a static libsecp256k1. Without this change, because libsecp256k1.a ends up with exported symbols, we end up with libsecp256k1 symbols exported by our libbitcoin-kernel library (which causes unrelated problems not worth getting into here). libtool takes care of building both object versions, and it automatically builds objects for shared libs with -DDLL_EXPORT. We just need to opt-in to its functionality. I can't imagine this having any negative impact on any current statically-linking applications, if anything they'll just be a tiny bit smaller because they can now strip unused symbols. ACKs for top commit: real-or-random: utACK 6f6cab9 theuni: > Not sure what other changes made compilation on CI fail but Concept ACK [6f6cab9](bitcoin-core/secp256k1@6f6cab9). This should be entirely harmless. sipa: utACK 6f6cab9 laanwj: utACK 6f6cab9 Tree-SHA512: 39f240046639738f7a8c01068e728b2f9ceac2754cc4b0a5fa46c28f6f57a8c4124653b56dfbf5c13106b07c11ac599cc41b508e16862d539ce1af6c3365a205
Configuration menu - View commit details
-
Copy full SHA for 44c2452 - Browse repository at this point
Copy the full SHA 44c2452View commit details
Commits on Jun 29, 2022
-
Configuration menu - View commit details
-
Copy full SHA for bd81f41 - Browse repository at this point
Copy the full SHA bd81f41View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2be6ba0 - Browse repository at this point
Copy the full SHA 2be6ba0View commit details -
This adds MSVC builds built on Linux using wine. This requires some settings of tools and flags because the autotools support for MSVC is naturally somewhat limited. The advantage of this approach is that it is compatible with our existing CI scripts, so there's no need to write a Windows CI script (in PowerShell or similar). If we want to test building and running on Windows native (e.g., as supported by Cirrus CI) we could still do this in the future. Another advantage of this approach is that contributors can simply use the docker image if they need a MSVC installation in a non-Windows environment. This commit also improves the Dockerfile by grouping RUN commands according to Docker docs: https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#run
Configuration menu - View commit details
-
Copy full SHA for 9efc2e5 - Browse repository at this point
Copy the full SHA 9efc2e5View commit details -
This commit also raises the TEST_ITERS for wine tasks to the default. The overhead of wine is negligible, so we can certainly afford the same number of iterations as for native Linux tests.
Configuration menu - View commit details
-
Copy full SHA for 3fb3269 - Browse repository at this point
Copy the full SHA 3fb3269View commit details -
Configuration menu - View commit details
-
Copy full SHA for 51f296a - Browse repository at this point
Copy the full SHA 51f296aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8dc4b03 - Browse repository at this point
Copy the full SHA 8dc4b03View commit details -
Configuration menu - View commit details
-
Copy full SHA for 49e2acd - Browse repository at this point
Copy the full SHA 49e2acdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1827c9b - Browse repository at this point
Copy the full SHA 1827c9bView commit details -
Merge bitcoin-core/secp256k1#1084: ci: Add MSVC builds
49e2acd configure: Improve rationale for WERROR_CFLAGS (Tim Ruffing) 8dc4b03 ci: Add a C++ job that compiles the public headers without -fpermissive (Tim Ruffing) 51f296a ci: Run persistent wineserver to speed up wine (Tim Ruffing) 3fb3269 ci: Add 32-bit MinGW64 build (Tim Ruffing) 9efc2e5 ci: Add MSVC builds (Tim Ruffing) 2be6ba0 configure: Convince autotools to work with MSVC's archiver lib.exe (Tim Ruffing) bd81f41 schnorrsig bench: Suppress a stupid warning in MSVC (Tim Ruffing) 09f3d71 configure: Add a few CFLAGS for MSVC (Tim Ruffing) 3b4f3d0 build: Reject C++ compilers in the preprocessor (Tim Ruffing) 1cc0941 configure: Don't abort if the compiler does not define __STDC__ (Tim Ruffing) cca8cbb configure: Output message when checking for valgrind (Tim Ruffing) 1a6be57 bench: Make benchmarks compile on MSVC (Tim Ruffing) Pull request description: ACKs for top commit: jonasnick: ACK 49e2acd Tree-SHA512: 986c498fb218231fff3519167d34a92e11dea6a4383788a9723be105c20578cd483c6b06ba5686c6669e3a02cfeebc29b8e5f1428552ebf4ec67fa7a86957548
Configuration menu - View commit details
-
Copy full SHA for cd47033 - Browse repository at this point
Copy the full SHA cd47033View commit details -
Merge bitcoin-core/secp256k1#1114:
_scratch_destroy
: move `VERIFY_C……HECK` after invalid scrach space check 1827c9b scratch_destroy: move VERIFY_CHECK after invalid scrach space check (siv2r) Pull request description: ACKs for top commit: sipa: utACK 1827c9b jonasnick: ACK 1827c9b Tree-SHA512: 5c4f97ca16f46380b30d1d077a54e25eab21efb10e0ce3ca27e7f73a2318d130f0f0773e26b2fdfc8f9d98c1334880f9d80a51b0941be3ba0af2b656b7c0ea7e
Configuration menu - View commit details
-
Copy full SHA for accadc9 - Browse repository at this point
Copy the full SHA accadc9View commit details
Commits on Jun 30, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 069aba8 - Browse repository at this point
Copy the full SHA 069aba8View commit details -
Merge bitcoin-core/secp256k1#1115: Fix sepc256k1 -> secp256k1 typo in…
Configuration menu - View commit details
-
Copy full SHA for 43756da - Browse repository at this point
Copy the full SHA 43756daView commit details
Commits on Jul 1, 2022
-
build: Fix #include "..." paths to get rid of further -I arguments
This simplifies building without a build system. This is in line with #925; the paths fixed here were either forgotten there or only introduced later. This commit also makes the Makefile stricter so that further "wrong" #include paths will lead to build errors even in autotools builds. This belongs to #929. Co-authored-by: Hennadii Stepanov <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 40a3473 - Browse repository at this point
Copy the full SHA 40a3473View commit details -
Merge bitcoin-core/secp256k1#1116: build: Fix #include "..." paths to…
… get rid of further -I arguments 40a3473 build: Fix #include "..." paths to get rid of further -I arguments (Tim Ruffing) Pull request description: This simplifies building without a build system. This is in line with #925; the paths fixed here were either forgotten there or only introduced later. This commit also makes the Makefile stricter so that further "wrong" #include paths will lead to build errors even in autotools builds. This belongs to #929. ACKs for top commit: hebasto: ACK 40a3473 Tree-SHA512: 6f4d825ea3cf86b13f294e2ec19fafc29660fa99450e6b579157d7a6e9bdb3404d761edf89c1135fa89b984d6431a527beeb97031dc90f2fae9761528f4d06d1
Configuration menu - View commit details
-
Copy full SHA for af65d30 - Browse repository at this point
Copy the full SHA af65d30View commit details
Commits on Jul 5, 2022
-
ecmult_gen: Skip RNG when creating blinding if no seed is available
Running the RNG is pointless if no seed is available because the key will be fixed. The computation just wastes time. Previously, users could avoid this computation at least by asking for a context without signing capabilities. But since 3b0c218 we always build an ecmult_gen context, ignoring the context flags. Moreover, users could never avoid this pointless computation when asking for the creation of a signing context.
Configuration menu - View commit details
-
Copy full SHA for 4cc0b1b - Browse repository at this point
Copy the full SHA 4cc0b1bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a86955 - Browse repository at this point
Copy the full SHA 7a86955View commit details -
ecmult_gen: Improve comments about projective blinding
Whenever I read this code, I first think that rescaling ctx->initial is a dead store because we overwrite it later with gb. But that's wrong. The rescaling blinds the computation of gb and affects its result.
Configuration menu - View commit details
-
Copy full SHA for 55f8bc9 - Browse repository at this point
Copy the full SHA 55f8bc9View commit details
Commits on Jul 6, 2022
-
config: Set preprocessor defaults for ECMULT_* config values
This simplifies manual builds and solves one item in #929.
Configuration menu - View commit details
-
Copy full SHA for d0cf55e - Browse repository at this point
Copy the full SHA d0cf55eView commit details
Commits on Jul 7, 2022
-
Merge bitcoin-core/secp256k1#1120: ecmult_gen: Skip RNG when creating…
… blinding if no seed is available 55f8bc9 ecmult_gen: Improve comments about projective blinding (Tim Ruffing) 7a86955 ecmult_gen: Simplify code (no observable change) (Tim Ruffing) 4cc0b1b ecmult_gen: Skip RNG when creating blinding if no seed is available (Tim Ruffing) Pull request description: Running the RNG is pointless if no seed is available because the key will be fixed. The computation just wastes time. Previously, users could avoid this computation at least by asking for a context without signing capabilities. But since 3b0c218 we always build an ecmult_gen context, ignoring the context flags. Moreover, users could never avoid this pointless computation when asking for the creation of a signing context. This fixes one item in #1065. ACKs for top commit: sipa: ACK 55f8bc9 apoelstra: ACK 55f8bc9 Tree-SHA512: 5ccba56041f94fa8f40a8a56ce505369ff2e0ed20cd7f0bfc3fdfffa5fa7bf826a93602b9b2455a352865a9548ab4928e858c19bb5af7ec221594a3bf25c4f3d
Configuration menu - View commit details
-
Copy full SHA for 63a3565 - Browse repository at this point
Copy the full SHA 63a3565View commit details -
Configuration menu - View commit details
-
Copy full SHA for da6514a - Browse repository at this point
Copy the full SHA da6514aView commit details -
It's unused and thus potentially confusing.
Configuration menu - View commit details
-
Copy full SHA for c27ae45 - Browse repository at this point
Copy the full SHA c27ae45View commit details
Commits on Jul 8, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 17065f4 - Browse repository at this point
Copy the full SHA 17065f4View commit details
Commits on Jul 11, 2022
-
Merge bitcoin-core/secp256k1#1122: tests: Randomize the context with …
…probability 15/16 instead of 1/4 17065f4 tests: Randomize the context with probability 15/16 instead of 1/4 (Tim Ruffing) Pull request description: ACKs for top commit: sipa: ACK 17065f4 jonasnick: ACK 17065f4 Tree-SHA512: 3b7005770007b922a294be610f23da60b0dde74dfd7585d64a2cb04eaa6ec879de8d21a0ade31c1857019a8dd97260fa3aa167ae16fc55027ef280a3e3feaa6d
Configuration menu - View commit details
-
Copy full SHA for 6a873cc - Browse repository at this point
Copy the full SHA 6a873ccView commit details -
Merge bitcoin-core/secp256k1#1121: config: Set preprocessor defaults …
…for ECMULT_* config values c27ae45 config: Remove basic-config.h (Tim Ruffing) da6514a config: Introduce DEBUG_CONFIG macro for debug output of config (Tim Ruffing) d0cf55e config: Set preprocessor defaults for ECMULT_* config values (Tim Ruffing) Pull request description: ACKs for top commit: sipa: ACK c27ae45 hebasto: ACK c27ae45, I have reviewed the code and it looks correct. jonasnick: ACK c27ae45 Tree-SHA512: 56b0f384bd9f42cf7c903bec08f4807db1415ddf9a06676dfe1e638e4d02431c522ef0422585e85429074e0dbb51da4f400cf53e8f883d6e07122731c57be1e3
Configuration menu - View commit details
-
Copy full SHA for 3efeb9d - Browse repository at this point
Copy the full SHA 3efeb9dView commit details
Commits on Jul 21, 2022
-
configure: Remove pkgconfig macros again (reintroduced by mismerge)
Configuration menu - View commit details
-
Copy full SHA for cabe085 - Browse repository at this point
Copy the full SHA cabe085View commit details -
Merge bitcoin-core/secp256k1#1128: configure: Remove pkgconfig macros…
… again (reintroduced by mismerge) cabe085 configure: Remove pkgconfig macros again (reintroduced by mismerge) (Tim Ruffing) Pull request description: We had removed `PKG_PROG_PKG_CONFIG` in 21b2eba (#1090). But then then the not rebased (!) merge of 2be6ba0 (#1084) brought that macro back at another location, without git complaining about a conflict. Fixes #1127. ACKs for top commit: fanquake: ACK cabe085 hebasto: ACK cabe085 jonasnick: ACK cabe085 Tree-SHA512: ba497503db3a11e631b15c4fe875e62d892971c2c708d90b2f6be684e85d164043ea97c13af0452831eef41f3cf8230cd8a9eafa332dc5b5ae18e118b87c3828
Configuration menu - View commit details
-
Copy full SHA for 9f8a13d - Browse repository at this point
Copy the full SHA 9f8a13dView commit details
Commits on Aug 2, 2022
-
Configuration menu - View commit details
-
Copy full SHA for ef48f08 - Browse repository at this point
Copy the full SHA ef48f08View commit details -
Configuration menu - View commit details
-
Copy full SHA for 78f5296 - Browse repository at this point
Copy the full SHA 78f5296View commit details -
Configuration menu - View commit details
-
Copy full SHA for 88b0089 - Browse repository at this point
Copy the full SHA 88b0089View commit details -
Merge bitcoin-core/secp256k1#1131: readme: Misc improvements
88b0089 readme: Fix line break (Tim Ruffing) 78f5296 readme: Sell "no runtime dependencies" (Tim Ruffing) ef48f08 readme: Add IRC channel (Tim Ruffing) Pull request description: ACKs for top commit: apoelstra: utACK 88b0089 sipa: ACK 88b0089 Tree-SHA512: 174f1596406f98a19059a18cd4fb993102e5ffb8ec29fcc6d03e27f135fcb526b37204b64055b5e4f0a273daab05d395cf335f26241cf3a29a060041c9ef109b
Configuration menu - View commit details
-
Copy full SHA for 694ce8f - Browse repository at this point
Copy the full SHA 694ce8fView commit details
Commits on Aug 3, 2022
-
build: Enable some modules by default
We don't enable the ECDSA recovery module, because we don't recommend ECDSA recovery for new protocols. In particular, the recovery API is prone to misuse: It invites the caller to forget to check the public key (and the verification function always returns 1). In general, we also don't recommend ordinary ECDSA for new protocols. But disabling the ECDSA functions is not possible because they're not in a module, and let's be honest: disabling ECDSA would mean to ignore reality blatantly.
Configuration menu - View commit details
-
Copy full SHA for 41e8704 - Browse repository at this point
Copy the full SHA 41e8704View commit details
Commits on Oct 28, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 798727a - Browse repository at this point
Copy the full SHA 798727aView commit details -
The removed line was introduced for `obj/.gitignore` file. Since the `obj` directory has been removed, it is not longer required.
Configuration menu - View commit details
-
Copy full SHA for f5039cb - Browse repository at this point
Copy the full SHA f5039cbView commit details
Commits on Nov 1, 2022
-
Merge bitcoin-core/secp256k1#1144: Cleanup
.gitignore
filef5039cb Cleanup `.gitignore` file (Hennadii Stepanov) 798727a Revert "Add test logs to gitignore" (Hennadii Stepanov) Pull request description: ACKs for top commit: jonasnick: ACK f5039cb real-or-random: ACK f5039cb Tree-SHA512: 3586329e77958a9bfa06dd84e5b121cd456e93332670d5afc1a6691e165cdfa5a6fd6a61f82be12ec33f2a58b26a13adfedeb177ae1056202e53a530949fc549
Configuration menu - View commit details
-
Copy full SHA for a43e982 - Browse repository at this point
Copy the full SHA a43e982View commit details
Commits on Nov 2, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 4e54c03 - Browse repository at this point
Copy the full SHA 4e54c03View commit details -
ci: mostly prevent "-v/--version: not found" irrelevant error
$CC, $WRAPPER_CMD and valgrind are not necessarily defined
Configuration menu - View commit details
-
Copy full SHA for 49ae843 - Browse repository at this point
Copy the full SHA 49ae843View commit details
Commits on Nov 7, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 5c9f1a5 - Browse repository at this point
Copy the full SHA 5c9f1a5View commit details -
Remove usage of CHECK from non-test file
Currently CHECK is used only in test and bench mark files except for one usage in `ecmult_impl.h`. We would like to move the definition of CHECK out of `util.h` so that `util.h` no longer has a hard dependency on `stdio.h`. Done in preparation for moving the definition of `CHECK` as part of an effort to allow secp256k1 to be compiled to WASM as part of `rust-secp256k1`.
Configuration menu - View commit details
-
Copy full SHA for 6a965b6 - Browse repository at this point
Copy the full SHA 6a965b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2914bcc - Browse repository at this point
Copy the full SHA 2914bccView commit details -
int128: Tidy #includes of int128.h and int128_impl.h
After this commit, int128.h and int128_impl.h are included as follows: - .c files which use int128 include int128_impl.h (after util.h) - .h files which use int128 include int128.h (after util.h) This list is exhaustive. util.h needs to included first because it sets up necessary #defines.
Configuration menu - View commit details
-
Copy full SHA for dceaa1f - Browse repository at this point
Copy the full SHA dceaa1fView commit details -
Configuration menu - View commit details
-
Copy full SHA for a340d95 - Browse repository at this point
Copy the full SHA a340d95View commit details
Commits on Nov 8, 2022
-
Merge bitcoin-core/secp256k1#1150: ci: always cat test_env.log
Configuration menu - View commit details
-
Copy full SHA for e13fae4 - Browse repository at this point
Copy the full SHA e13fae4View commit details -
Merge bitcoin-core/secp256k1#1146: ci: prevent "-v/--version: not fou…
…nd" irrelevant error 49ae843 ci: mostly prevent "-v/--version: not found" irrelevant error (Jonas Nick) Pull request description: ACKs for top commit: real-or-random: ACK 49ae843 Tree-SHA512: 2e048b037826dff372e26103f198e0d490494e7909d17d8632b51f6d9e0629b51bcd0b55b65b2c21d63d522394ccfed481ce126cea165c087df670556bc8ccf6
Configuration menu - View commit details
-
Copy full SHA for c2ee917 - Browse repository at this point
Copy the full SHA c2ee917View commit details
Commits on Nov 14, 2022
-
Merge bitcoin-core/secp256k1#1147: ci: print env to allow reproducing…
… the job outside of CI 4e54c03 ci: print env to allow reproducing the job outside of CI (Jonas Nick) Pull request description: Example output: ``` WERROR_CFLAGS="-Werror -pedantic-errors" MAKEFLAGS="-j4" BUILD="check" ECMULTWINDOW="auto" ECMULTGENPRECISION="auto" ASM="no" WIDEMUL="int64" WITH_VALGRIND="no" EXTRAFLAGS="" EXPERIMENTAL="no" ECDH="no" RECOVERY="yes" SCHNORRSIG="no" SECP256K1_TEST_ITERS="" BENCH="yes" SECP256K1_BENCH_ITERS="2" CTIMETEST="yes" EXAMPLES="yes" WRAPPER_CMD="" CC="gcc" AR="" NM="" HOST="" ./ci/cirrus.sh ``` ACKs for top commit: sipa: ACK 4e54c03 real-or-random: ACK bitcoin-core/secp256k1@4e54c03 Tree-SHA512: b74a8724e72b3de7884e4d93fe933dc5043aec37020672b7997a8faebda3b0cbbba1bca69c344109729261ab4a94e76f4eca0d8773dc101a443fdf9e0d7d54f5
Configuration menu - View commit details
-
Copy full SHA for 44916ae - Browse repository at this point
Copy the full SHA 44916aeView commit details
Commits on Nov 16, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 00a42b9 - Browse repository at this point
Copy the full SHA 00a42b9View commit details -
Merge bitcoin-core/secp256k1#1149: Remove usage of CHECK from non-tes…
…t file 6a965b6 Remove usage of CHECK from non-test file (Tobin C. Harding) Pull request description: Currently CHECK is used only in test and bench mark files except for one usage in `ecmult_impl.h`. We would like to move the definition of CHECK out of `util.h` so that `util.h` no longer has a hard dependency on `stdio.h`. Done as part of an effort to allow secp256k1 to be compiled to WASM as part of `rust-secp256k1`. ### Note to reviewers Please review carefully, I don't actually know if this patch is correct. Done while working on #1095. I'm happy to make any changes both in concept and execution - I'm super rusty at C programming. cc real-or-random ACKs for top commit: sipa: utACK 6a965b6 real-or-random: utACK 6a965b6 Tree-SHA512: 6bfb456bdb92a831acd3bc202607e80f6d0a194d6b2cf745c8eceb12ba675d03a319d6d105332b0cbca474e443969295e5a8e938635453e21e057d0ee597440b
Configuration menu - View commit details
-
Copy full SHA for 86e3b38 - Browse repository at this point
Copy the full SHA 86e3b38View commit details -
Merge bitcoin-core/secp256k1#1000: Synthetic int128 type.
a340d95 ci: add int128_struct tests (Jonas Nick) dceaa1f int128: Tidy #includes of int128.h and int128_impl.h (Tim Ruffing) 2914bcc Simulated int128 type. (Russell O'Connor) Pull request description: Abstracts the int128 type and provides an native version, if available, or a implements it using a pair of int64_t's. This is activated by setting the configuration flag `--with-test-override-wide-multiply=int128_struct`. The primary purpose of this PR is to take advantage of MSVC's [umulh](https://docs.microsoft.com/en-us/cpp/intrinsics/umulh?view=msvc-170) intrinsic that we can use to simulate an int128 type which MSVC does not have (AFAIU). This PR lays out the groundwork for this level of MSVC support, but doesn't include the configuration logic to enable it yet. For completeness, and implementation of `umulh` and `mulh` are also provided for compilers that support neither the intrinsic nor the int128 type (such as CompCert?). This also opens up the possibility of removing the 32-bit field and scalar implementations should that ever be desired. ACKs for top commit: sipa: ACK a340d95 jonasnick: ACK a340d95 Tree-SHA512: b4f2853fa3ab60ce9d77b4eaee1fd20c4b612850e19fcb3179d7e36986f420c6c4589ff72f0cf844f989584ace49a1cd23cca3f4e405dabefc8da647a0df679d
Configuration menu - View commit details
-
Copy full SHA for ddf2b29 - Browse repository at this point
Copy the full SHA ddf2b29View commit details
Commits on Nov 17, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 6138d73 - Browse repository at this point
Copy the full SHA 6138d73View commit details -
Configuration menu - View commit details
-
Copy full SHA for f2b7e88 - Browse repository at this point
Copy the full SHA f2b7e88View commit details -
int128: Add test override for testing __(u)mulh on MSVC X64
Also add a corresponding CI job
Configuration menu - View commit details
-
Copy full SHA for 63ff064 - Browse repository at this point
Copy the full SHA 63ff064View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b5f589 - Browse repository at this point
Copy the full SHA 9b5f589View commit details -
Configuration menu - View commit details
-
Copy full SHA for c0ae48c - Browse repository at this point
Copy the full SHA c0ae48cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3afce0a - Browse repository at this point
Copy the full SHA 3afce0aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a8494b0 - Browse repository at this point
Copy the full SHA a8494b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 99bd335 - Browse repository at this point
Copy the full SHA 99bd335View commit details
Commits on Nov 18, 2022
-
Merge bitcoin-core/secp256k1#1156: Followups to int128_struct arithmetic
99bd335 Make int128 overflow test use secp256k1_[ui]128_mul (Pieter Wuille) 3afce0a Avoid signed overflow in MSVC AMR64 secp256k1_mul128 (Pieter Wuille) 9b5f589 Heuristically decide whether to use int128_struct (Pieter Wuille) 63ff064 int128: Add test override for testing __(u)mulh on MSVC X64 (Tim Ruffing) f2b7e88 Add int128 randomized tests (Pieter Wuille) Pull request description: This is a follow-up to #1000: * Add randomized unit tests for int128 logic. * Add CI for the `_(u)mulh` code path (on non-ARM64 MSVC). * Add heuristic logic to enable int128_struct based arithmetic on 64-bit MSVC, or systems with pointers wider than 32 bits. * Fix signed overflow in ARM64 MSVC code. ACKs for top commit: roconnor-blockstream: utACK 99bd335 real-or-random: ACK 99bd335 tested this also on MSVC locally with the override, including all the benchmark binaries jonasnick: utACK 99bd335 Tree-SHA512: 5ea897362293b45a86650593e1fdc8c4004a1d9452eed2fa070d22dffc7ed7ca1ec50a4df61e3a33dbe35e08132ad9686286ac44af6742b32b82f11c9d3341c6
Configuration menu - View commit details
-
Copy full SHA for e40fd27 - Browse repository at this point
Copy the full SHA e40fd27View commit details
Commits on Nov 21, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 4bc4290 - Browse repository at this point
Copy the full SHA 4bc4290View commit details -
Configuration menu - View commit details
-
Copy full SHA for d216475 - Browse repository at this point
Copy the full SHA d216475View commit details
Commits on Nov 22, 2022
-
Merge bitcoin-core/secp256k1#993: Enable non-experimental modules by …
…default 41e8704 build: Enable some modules by default (Tim Ruffing) Pull request description: This has been discussed in bitcoin-core/secp256k1#817 (comment) and I agree with the arguments brought up there. Alternatively, we could not enable them and add a discussion to the readme why we discourage people from using the modules. I believe enabling ECDH is not very controversial. But what about recovery? Do we want to leave it off and instead give a reason? ACKs for top commit: sipa: ACK 41e8704 jonasnick: ACK 41e8704 Tree-SHA512: 1dd21037043f2b2c94a92cd2f31e69b505ba5b43119897bc0934966d9ccd84fc4fc20e7509af634f1c3a096710db1a2253090f5f1f107b9d258945a5546e9ba4
Configuration menu - View commit details
-
Copy full SHA for 2286f80 - Browse repository at this point
Copy the full SHA 2286f80View commit details
Commits on Nov 24, 2022
-
Merge bitcoin-core/secp256k1#1152: Update macOS image for CI
a8494b0 Use compute credits for macOS jobs (Pieter Wuille) c0ae48c Update macOS image for CI (Pieter Wuille) Pull request description: ACKs for top commit: real-or-random: ACK a8494b0 jonasnick: ACK a8494b0 Tree-SHA512: af99585ef68fc8305785885efaf0a0ebe45e5765661d654523a36ba843fc83e0ac40a554638437fa53804e4aa42dbcd92d597702ee6225b66a044a6304bafd45
Configuration menu - View commit details
-
Copy full SHA for 751c435 - Browse repository at this point
Copy the full SHA 751c435View commit details
Commits on Nov 25, 2022
-
Configuration menu - View commit details
-
Copy full SHA for ee7341f - Browse repository at this point
Copy the full SHA ee7341fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a553ee - Browse repository at this point
Copy the full SHA 1a553eeView commit details
Commits on Dec 1, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 092be61 - Browse repository at this point
Copy the full SHA 092be61View commit details -
Merge bitcoin-core/secp256k1#1165: gitignore: Add *.sage.py files aut…
…ogenerated by sage [skip ci] 092be61 gitignore: Add *.sage.py files autogenerated by sage (Tim Ruffing) Pull request description: ACKs for top commit: jonasnick: ACK 092be61 Tree-SHA512: ee77e8634814ccc1894eb633816da877a4d4511d9e77f5628b19e0e37006d43ae45431dfd1b30977504a5975a92a2b1824ed53c7837fb5600994d11003996b86
Configuration menu - View commit details
-
Copy full SHA for 477f02c - Browse repository at this point
Copy the full SHA 477f02cView commit details
Commits on Dec 5, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 316ac76 - Browse repository at this point
Copy the full SHA 316ac76View commit details -
Configuration menu - View commit details
-
Copy full SHA for 72fedf8 - Browse repository at this point
Copy the full SHA 72fedf8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 53796d2 - Browse repository at this point
Copy the full SHA 53796d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for d2c6d48 - Browse repository at this point
Copy the full SHA d2c6d48View commit details -
Configuration menu - View commit details
-
Copy full SHA for e383fbf - Browse repository at this point
Copy the full SHA e383fbfView commit details -
Configuration menu - View commit details
-
Copy full SHA for e02d686 - Browse repository at this point
Copy the full SHA e02d686View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0612636 - Browse repository at this point
Copy the full SHA 0612636View commit details -
Configuration menu - View commit details
-
Copy full SHA for e7d0185 - Browse repository at this point
Copy the full SHA e7d0185View commit details -
docs: Use doxygen style if and only if comment is user-facing
and improve phrasing slightly.
Configuration menu - View commit details
-
Copy full SHA for 7289b51 - Browse repository at this point
Copy the full SHA 7289b51View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4386a23 - Browse repository at this point
Copy the full SHA 4386a23View commit details
Commits on Dec 6, 2022
-
Merge bitcoin-core/secp256k1#1126: API cleanup with respect to contexts
4386a23 examples: Switch to NONE contexts (Tim Ruffing) 7289b51 docs: Use doxygen style if and only if comment is user-facing (Tim Ruffing) e7d0185 docs: Get rid of "initialized for signing" terminology (Tim Ruffing) 0612636 docs: Tidy and improve docs about contexts and randomization (Tim Ruffing) e02d686 selftest: Expose in public API (Tim Ruffing) e383fbf selftest: Rename internal function to make name available for API (Tim Ruffing) d2c6d48 tests: Use new name of static context (Tim Ruffing) 53796d2 contexts: Rename static context (Tim Ruffing) 72fedf8 docs: Improve docs for static context (Tim Ruffing) 316ac76 contexts: Deprecate all context flags except SECP256K1_CONTEXT_NONE (Tim Ruffing) 1a553ee docs: Change signature "validation" to "verification" (Tim Ruffing) ee7341f docs: Never require a verification context (Tim Ruffing) Pull request description: ACKs for top commit: sipa: utACK 4386a23 jonasnick: ACK 4386a23 Tree-SHA512: 7bf07dfae0ecbf7de1418de64ef743a23dc5f244aeba2c1cf3ecbdc117d6ac12bb6c8f17f739605566074a9b901765ee4a32288b6edc6f9a0040a70cb472f6ee
Configuration menu - View commit details
-
Copy full SHA for e3f8477 - Browse repository at this point
Copy the full SHA e3f8477View commit details -
Configuration menu - View commit details
-
Copy full SHA for 90618e9 - Browse repository at this point
Copy the full SHA 90618e9View commit details
Commits on Dec 7, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 8d7a9a8 - Browse repository at this point
Copy the full SHA 8d7a9a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 37ba744 - Browse repository at this point
Copy the full SHA 37ba744View commit details -
Configuration menu - View commit details
-
Copy full SHA for caa0ad6 - Browse repository at this point
Copy the full SHA caa0ad6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 86540e9 - Browse repository at this point
Copy the full SHA 86540e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c8a5ca - Browse repository at this point
Copy the full SHA 0c8a5caView commit details -
Configuration menu - View commit details
-
Copy full SHA for d6dc0f4 - Browse repository at this point
Copy the full SHA d6dc0f4View commit details -
Merge bitcoin-core/secp256k1#1168: Replace deprecated context flags w…
…ith NONE in benchmarks and tests d6dc0f4 tests: Switch to NONE contexts in module tests (Jonas Nick) 0c8a5ca tests: Switch to NONE contexts in tests.c (Jonas Nick) 86540e9 tests: add test for deprecated flags and rm them from run_context (Jonas Nick) caa0ad6 group: add gej_eq_var (Jonas Nick) 37ba744 tests: Switch to NONE contexts in exhaustive and ctime tests (Jonas Nick) 8d7a9a8 benchmarks: Switch to NONE contexts (Jonas Nick) Pull request description: Based on #1126. ACKs for top commit: real-or-random: ACK d6dc0f4 diff looks good and tests pass locally sipa: utACK d6dc0f4 Tree-SHA512: 1fb1dc1336409b52827787a03c791a21ee1d6b1bdc388d1fa126600572f348ba16865a01d29bac67b36b8f29f30cda117d82913e2044ccb9d073f5d04338ac9f
Configuration menu - View commit details
-
Copy full SHA for 5c789dc - Browse repository at this point
Copy the full SHA 5c789dcView commit details -
build: change package version to 0.1.0-dev
The suffix -dev is slightly clearer. Also, since the package version follows semantic versioning, rename VERSION_BUILD to VERSION_PATCH for clarity.
Configuration menu - View commit details
-
Copy full SHA for ad39e2d - Browse repository at this point
Copy the full SHA ad39e2dView commit details
Commits on Dec 8, 2022
-
Configuration menu - View commit details
-
Copy full SHA for cf66f23 - Browse repository at this point
Copy the full SHA cf66f23View commit details -
Configuration menu - View commit details
-
Copy full SHA for c635c1b - Browse repository at this point
Copy the full SHA c635c1bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2551cda - Browse repository at this point
Copy the full SHA 2551cdaView commit details -
Configuration menu - View commit details
-
Copy full SHA for a49e094 - Browse repository at this point
Copy the full SHA a49e094View commit details
Commits on Dec 12, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 7e5b226 - Browse repository at this point
Copy the full SHA 7e5b226View commit details -
- make version on master always equal to latest release with patch+1 - separate regular from maintenance releases - add more git commands to prevent accidents - mention that one needs to somehow deal with release dates - _LIB_VERSIONS_ -> _LIB_VERSION_ - don't push all tags in step 4 - add required message to git tag - add suggested commit messages
Configuration menu - View commit details
-
Copy full SHA for b1f992a - Browse repository at this point
Copy the full SHA b1f992aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 13bf1b6 - Browse repository at this point
Copy the full SHA 13bf1b6View commit details -
Merge bitcoin-core/secp256k1#1173: Don't use compute credits for now
Configuration menu - View commit details
-
Copy full SHA for 8c949f5 - Browse repository at this point
Copy the full SHA 8c949f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d1784a - Browse repository at this point
Copy the full SHA 6d1784aView commit details -
release: prepare for initial release 0.2.0
There are plenty of unreleased variants of libsecp256k1 version 0.1.0 (libsecp256k1.so.0.0.0) in the wild. We choose a new version number to allow a clear distinction. There are variants of 0.1.0 that are incompatible with the initial release, hence we increase the minor version to arrive at version number 0.2.0. For the same reason, we increase the LIB_VERSION_CURRENT and keep AGE at 0. The changelog for 0.2.0 consists of the relevant changes since 2021-12-25, which is the date when the initial release process PR was merged (and the library version was set to a pre-release, see 423b6d1). This is somewhat arbitrary but at least points readers to relevant changes.
Configuration menu - View commit details
-
Copy full SHA for e025ccd - Browse repository at this point
Copy the full SHA e025ccdView commit details -
Merge bitcoin-core/secp256k1#1055: Prepare initial release
e025ccd release: prepare for initial release 0.2.0 (Jonas Nick) 6d1784a build: add missing files to EXTRA_DIST (Jonas Nick) 13bf1b6 changelog: make order of change types match keepachangelog.com (Jonas Nick) b1f992a doc: improve release process (Jonas Nick) ad39e2d build: change package version to 0.1.0-dev (Jonas Nick) 90618e9 doc: move CHANGELOG from doc/ to root directory (Jonas Nick) Pull request description: Based on #964 ACKs for top commit: sipa: ACK e025ccd Tree-SHA512: b9ab71d7362537d383a32b5e321ef44069f00e3e92340375bcd662267bc5a60c2bad60222998e6602cfac24ad65efb23d772eac37c86065036b90ef090b54c49
Configuration menu - View commit details
-
Copy full SHA for 21ffe4b - Browse repository at this point
Copy the full SHA 21ffe4bView commit details -
Configuration menu - View commit details
-
Copy full SHA for b6b360e - Browse repository at this point
Copy the full SHA b6b360eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 02ebc29 - Browse repository at this point
Copy the full SHA 02ebc29View commit details -
Merge bitcoin-core/secp256k1#1174: release cleanup: bump version afte…
…r 0.2.0 02ebc29 release cleanup: bump version after 0.2.0 (Jonas Nick) b6b360e doc: improve message of cleanup commit (Jonas Nick) Pull request description: ACKs for top commit: sipa: ACK 02ebc29 Tree-SHA512: b887e31a531f7d21025558ed0a64ff5f68dee6feff8288478f7eb023189ceb20e5ca8baf0434ebd2ee49488d35d7aebc1b837888ff8c6e6420e6b86cc2f99cb1
Configuration menu - View commit details
-
Copy full SHA for 9a8d65f - Browse repository at this point
Copy the full SHA 9a8d65fView commit details
Commits on Dec 13, 2022
-
Configuration menu - View commit details
-
Copy full SHA for cee8223 - Browse repository at this point
Copy the full SHA cee8223View commit details -
Configuration menu - View commit details
-
Copy full SHA for ac233e1 - Browse repository at this point
Copy the full SHA ac233e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2dc133a - Browse repository at this point
Copy the full SHA 2dc133aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ecf814 - Browse repository at this point
Copy the full SHA 9ecf814View commit details
Commits on Dec 15, 2022
-
Remove dependency on
src/libsecp256k1-config.h
This change eases the use of alternate build systems by moving the variables in `src/libsecp256k1-config.h` to compiler macros for each invocation, preventing duplication of these variables for each build system. Co-authored-by: Ali Sherief <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b627ba7 - Browse repository at this point
Copy the full SHA b627ba7View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad8647f - Browse repository at this point
Copy the full SHA ad8647fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c5a4d2 - Browse repository at this point
Copy the full SHA 9c5a4d2View commit details
Commits on Dec 19, 2022
-
Configuration menu - View commit details
-
Copy full SHA for c2e0fda - Browse repository at this point
Copy the full SHA c2e0fdaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a74688 - Browse repository at this point
Copy the full SHA 7a74688View commit details -
Merge bitcoin-core/secp256k1#1154: ci: set -u in cirrus.sh to treat u…
…nset variables as an error 7a74688 ci: add missing CFLAGS & CPPFLAGS variable to print_environment (Jonas Nick) c2e0fda ci: set -u in cirrus.sh to treat unset variables as an error (Jonas Nick) Pull request description: This PR is supposed to prevent accidental misuse of cirrus.sh. Maybe there is a way to check if `CC`, `AR` and `NM` are set within the loop that deals with the other variables, but so far I did not come up with one (that's POSIX shell compliant). ACKs for top commit: real-or-random: ACK 7a74688 hebasto: re-ACK 7a74688 Tree-SHA512: 91e42b3f1192fbf86e6fb43942713e78b2bee977ddd95256ea7448f84324369399d31ec4eedd47af595bf994bbc9396e26bb5c93bdb7f58c4310b5d3d5d66731
Configuration menu - View commit details
-
Copy full SHA for 75d7b7f - Browse repository at this point
Copy the full SHA 75d7b7fView commit details
Commits on Dec 20, 2022
-
Merge bitcoin-core/secp256k1#1178: Drop
src/libsecp256k1-config.h
9c5a4d2 Do not define unused `HAVE_VALGRIND` macro (Hennadii Stepanov) ad8647f Drop no longer relevant files from `.gitignore` (Hennadii Stepanov) b627ba7 Remove dependency on `src/libsecp256k1-config.h` (Hennadii Stepanov) Pull request description: Cherry-picked the first commit from #1142 and addressed a [comment](bitcoin-core/secp256k1#1142 (comment)). ACKs for top commit: sipa: utACK 9c5a4d2 real-or-random: utACK 9c5a4d2 Tree-SHA512: c6f268261fc5edee855a7e69fdf9f6c5f4b859eb1e078e3c44c3ee4c9c445738af3de9fc2fbcca90db9b9e38681da8217faaeb0735201052b16ea397a7817db9
Configuration menu - View commit details
-
Copy full SHA for 665ba77 - Browse repository at this point
Copy the full SHA 665ba77View commit details -
Configuration menu - View commit details
-
Copy full SHA for 881fc33 - Browse repository at this point
Copy the full SHA 881fc33View commit details -
Configuration menu - View commit details
-
Copy full SHA for c30b889 - Browse repository at this point
Copy the full SHA c30b889View commit details -
Merge bitcoin-core/secp256k1#1177: Some improvements to the changelog
c30b889 Clarify that the ABI-incompatible versions are earlier (Pieter Wuille) 881fc33 Consistency in naming of modules (Pieter Wuille) 9ecf814 Reduce font size in changelog (Pieter Wuille) 2dc133a Add more changelog entries (Pieter Wuille) ac233e1 Add links to diffs to changelog (Pieter Wuille) cee8223 Mention semantic versioning in changelog (Pieter Wuille) Pull request description: ACKs for top commit: real-or-random: ACK c30b889 jonasnick: ACK c30b889 Tree-SHA512: 0f753eae0ea4d65035bfbcd81b90169111ea030cf7196dd072fb1ccc8aac1437768031f3fcef431584028da68b66873204e16e03bcde4a6ae96b08ab7f97a480
Configuration menu - View commit details
-
Copy full SHA for 3f57b9f - Browse repository at this point
Copy the full SHA 3f57b9fView commit details
Commits on Dec 21, 2022
-
Merge bitcoin-core/secp256k1#1171: Change ARG_CHECK_NO_RETURN to ARG_…
…CHECK_VOID which returns (void) a49e094 docs: Fix typo (Tim Ruffing) 2551cda tests: Fix code formatting (Tim Ruffing) c635c1b Change ARG_CHECK_NO_RETURN to ARG_CHECK_VOID which returns (void) (Tim Ruffing) cf66f23 refactor: Add helper function secp256k1_context_is_proper() (Tim Ruffing) Pull request description: ACKs for top commit: sipa: utACK a49e094 jonasnick: ACK a49e094 Tree-SHA512: 0fd4ee88510f2de0de96378ae69ce6e610a446000bb78597026c5924803e1ce5a4f76303fc6446233a6129f9c42dce1b1549f93bef935131101e47b5a69cdf2f
Configuration menu - View commit details
-
Copy full SHA for eacad90 - Browse repository at this point
Copy the full SHA eacad90View commit details -
Merge bitcoin-core/secp256k1#1158: Add a secp256k1_i128_to_u64 function.
d216475 test secp256k1_i128_to_i64 (Russell O'Connor) 4bc4290 Add a secp256k1_i128_to_u64 function. (Russell O'Connor) Pull request description: I wanted to experiment with what would be required to split up `secp256k1_i128_to_i64` between those cases when a signed 64 bit value is being demoted, versus an unsigned 64 bit value is being extracted from the lower bits, and this is the result. I'm not sure this is a useful PR, so feel free to close it. However, since it is already written, I figured it is worth at least discussing. ACKs for top commit: sipa: utACK d216475 real-or-random: ACK d216475 Tree-SHA512: 41dbb1d33b3078bee8e71a838cfad6f1859c0bba602ae061259add8e9e8ea5aa482daa41de79dbd7433ddbef4a0bc52757f3c45d63acc9c0eb05aa3ca891b922
Configuration menu - View commit details
-
Copy full SHA for 01b819a - Browse repository at this point
Copy the full SHA 01b819aView commit details
Commits on Dec 29, 2022
-
Configuration menu - View commit details
-
Copy full SHA for c0a555b - Browse repository at this point
Copy the full SHA c0a555bView commit details
Commits on Jan 2, 2023
-
Merge bitcoin-core/secp256k1#1183: Bugfix: pass SECP_CONFIG_DEFINES t…
…o bench compilation c0a555b Bugfix: pass SECP_CONFIG_DEFINES to bench compilation (Pieter Wuille) Pull request description: ACKs for top commit: real-or-random: utACK c0a555b apoelstra: ACK c0a555b Tree-SHA512: 4ec6ca4c012166beb6c5bdd1b2ed939554415e03545c176cf281000145c4000a460e231d5da26f617a81b048cd0fa3f8f16b61a207aed9479fdd854483e35ded
Configuration menu - View commit details
-
Copy full SHA for 31ed538 - Browse repository at this point
Copy the full SHA 31ed538View commit details
Commits on Jan 3, 2023
-
Drop
SECP_CONFIG_DEFINES
from examplesUser applications shouldn't need or rely on `SECP_CONFIG_DEFINES`.
Configuration menu - View commit details
-
Copy full SHA for 2f9ca28 - Browse repository at this point
Copy the full SHA 2f9ca28View commit details -
Merge bitcoin-core/secp256k1#1185: Drop
SECP_CONFIG_DEFINES
from ex……amples 2f9ca28 Drop `SECP_CONFIG_DEFINES` from examples (Hennadii Stepanov) Pull request description: User applications shouldn't need or rely on `SECP_CONFIG_DEFINES`. See bitcoin-core/secp256k1#1178 (comment). ACKs for top commit: sipa: utACK 2f9ca28 real-or-random: utACK 2f9ca28 Tree-SHA512: c8e81e6842b31e7f4ebcbb18d5962f7d7308f024025d6225330a7ec099739278bb43ad98243698c5802bcc49bf7e247ab7cae7f40008fbba87f0d0e46cbe1e85
Configuration menu - View commit details
-
Copy full SHA for 2a39ac1 - Browse repository at this point
Copy the full SHA 2a39ac1View commit details
Commits on Jan 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b198061 - Browse repository at this point
Copy the full SHA b198061View commit details -
Configuration menu - View commit details
-
Copy full SHA for 18e0db3 - Browse repository at this point
Copy the full SHA 18e0db3View commit details
Commits on Jan 5, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ce4f936 - Browse repository at this point
Copy the full SHA ce4f936View commit details -
Configuration menu - View commit details
-
Copy full SHA for f32a36f - Browse repository at this point
Copy the full SHA f32a36fView commit details -
Configuration menu - View commit details
-
Copy full SHA for fc90bb5 - Browse repository at this point
Copy the full SHA fc90bb5View commit details -
Configuration menu - View commit details
-
Copy full SHA for a4a0937 - Browse repository at this point
Copy the full SHA a4a0937View commit details -
Configuration menu - View commit details
-
Copy full SHA for 39e8f0e - Browse repository at this point
Copy the full SHA 39e8f0eView commit details
Commits on Jan 6, 2023
-
Merge bitcoin-core/secp256k1#1186: tests: Tidy context tests
39e8f0e refactor: Separate run_context_tests into static vs proper contexts (Tim Ruffing) a4a0937 tests: Clean up and improve run_context_tests() further (Tim Ruffing) fc90bb5 refactor: Tidy up main() (Tim Ruffing) f32a36f tests: Don't use global context for context tests (Tim Ruffing) ce4f936 tests: Tidy run_context_tests() by extracting functions (Tim Ruffing) 18e0db3 tests: Don't recreate global context in scratch space test (Tim Ruffing) b198061 tests: Use global copy of secp256k1_context_static instead of clone (Tim Ruffing) Pull request description: This is an improved version of some of the tidying/refactoring in #1170. I think it's enough to deserve a separate PR. Once this is merged, I'll get back to the actual goal of #1170 (namely, forbidding cloning and randomizing static contexts.) This PR is a general clean up of the context tests. A notable change is that this avoids a code smell where `run_context_tests()` would use the global `ctx` variable like a local one (i.e., create a context in it and destroy it afterwards). After this PR, the global `ctx` is properly initialized for all the other tests, and they can decide whether they want to use it or not. Same for a global `sttc`, which is a memcpy of the static context (we need a writable copy in order to be able to set callbacks). Note that this touches code which is also affected by #1167 but I refrained from trying to solve this issue. The goal of this PR is simply not to worsen the situation w.r.t. #1167. We should really introduce a macro to solve #1167 but that's another PR. ACKs for top commit: sipa: utACK 39e8f0e apoelstra: ACK 39e8f0e Tree-SHA512: a22471758111061a062b126a52a0de24a1a311d1a0332a4ef006882379a4f3f2b00e53089e3c374bf47c4051bb10bbc6a9fdbcf6d0cd4eca15b5703590395fba
Configuration menu - View commit details
-
Copy full SHA for 0eb3000 - Browse repository at this point
Copy the full SHA 0eb3000View commit details
Commits on Jan 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 2037600 - Browse repository at this point
Copy the full SHA 2037600View commit details
Commits on Jan 9, 2023
-
Merge bitcoin-core/secp256k1#1188: tests: Add noverify_tests which is…
… like tests but without VERIFY 2037600 tests: Add noverify_tests which is like tests but without VERIFY (Tim Ruffing) Pull request description: mentioned in bitcoin-core/secp256k1#1037 (comment) Let's see how this affects CI time ACKs for top commit: sipa: ACK 2037600 apoelstra: ACK 2037600 Tree-SHA512: fab1ce1499d418671d3d0ecfddf15d75b7c2bbfbfb4be958a95730491244185a906c7133aba4d0bec56ee6c721cb525750eef4cafc12f386484af931e34b0e8e
Configuration menu - View commit details
-
Copy full SHA for cbe41ac - Browse repository at this point
Copy the full SHA cbe41acView commit details
Commits on Jan 10, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 3385a26 - Browse repository at this point
Copy the full SHA 3385a26View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a93f48 - Browse repository at this point
Copy the full SHA 9a93f48View commit details
Commits on Jan 11, 2023
-
Merge bitcoin-core/secp256k1#1187: refactor: Rename global variables …
…in tests 9a93f48 refactor: Rename STTC to STATIC_CTX in tests (Tim Ruffing) 3385a26 refactor: Rename global variables to uppercase in tests (Tim Ruffing) Pull request description: On top of #1186 . I feel that this is an improvement, but it touches a lot of lines and so it deserves a separate discussion. ACKs for top commit: sipa: ACK 9a93f48 Tree-SHA512: b6dad2ffff2267034bf8cefdd3ef7ea11e9bcb8142d64b460ca61e0d3ab8de22fb3ee994dea0fb32feee3864d07395c070abffab318690d09d104294895300c4
Configuration menu - View commit details
-
Copy full SHA for cc3b8a4 - Browse repository at this point
Copy the full SHA cc3b8a4View commit details
Commits on Jul 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 9a98106 - Browse repository at this point
Copy the full SHA 9a98106View commit details -
Configuration menu - View commit details
-
Copy full SHA for 64717a7 - Browse repository at this point
Copy the full SHA 64717a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for e996d07 - Browse repository at this point
Copy the full SHA e996d07View commit details
Commits on Jul 18, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6c54db1 - Browse repository at this point
Copy the full SHA 6c54db1View commit details
Commits on Jul 20, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 304fc88 - Browse repository at this point
Copy the full SHA 304fc88View commit details -
build: Fix check of __builtin functions
Linking cannot possibly work without a main() function. Use AC_LANG_PROGRAM, which takes care of this automatically.
Configuration menu - View commit details
-
Copy full SHA for 9647687 - Browse repository at this point
Copy the full SHA 9647687View commit details