Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MuSig2 adaptor sig exercise in example code #188

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 35 additions & 3 deletions examples/musig.c
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
#include <secp256k1_musig.h>

#include "random.h"
#include <string.h>

struct signer_secrets {
secp256k1_keypair keypair;
Expand Down Expand Up @@ -98,6 +99,19 @@ int sign(const secp256k1_context* ctx, struct signer_secrets *signer_secrets, st
/* The same for all signers */
secp256k1_musig_session session;

/* For adapter signature, committing to random scalar */
unsigned char presig[64];
int nonce_parity;
unsigned char adaptor_key[32];
unsigned char extracted_adaptor[32];
secp256k1_pubkey adaptor;
if (!fill_random(adaptor_key, sizeof(adaptor_key))) {
return 0;
}
if (!secp256k1_ec_pubkey_create(ctx, &adaptor, adaptor_key)) {
return 0;
}

for (i = 0; i < N_SIGNERS; i++) {
unsigned char seckey[32];
unsigned char session_id[32];
Expand Down Expand Up @@ -126,7 +140,7 @@ int sign(const secp256k1_context* ctx, struct signer_secrets *signer_secrets, st
if (!secp256k1_musig_nonce_agg(ctx, &agg_pubnonce, pubnonces, N_SIGNERS)) {
return 0;
}
if (!secp256k1_musig_nonce_process(ctx, &session, &agg_pubnonce, msg32, cache, NULL)) {
if (!secp256k1_musig_nonce_process(ctx, &session, &agg_pubnonce, msg32, cache, &adaptor)) {
return 0;
}
/* partial_sign will clear the secnonce by setting it to 0. That's because
Expand Down Expand Up @@ -156,7 +170,25 @@ int sign(const secp256k1_context* ctx, struct signer_secrets *signer_secrets, st
return 0;
}
}
return secp256k1_musig_partial_sig_agg(ctx, sig64, &session, partial_sigs, N_SIGNERS);

/* Since we are doing adaptor sig, complete pre-signature */
if (!secp256k1_musig_nonce_parity(ctx, &nonce_parity, &session)) {
return 0;
}
if (!secp256k1_musig_partial_sig_agg(ctx, presig, &session, partial_sigs, N_SIGNERS)){
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (!secp256k1_musig_partial_sig_agg(ctx, presig, &session, partial_sigs, N_SIGNERS)){
if (!secp256k1_musig_partial_sig_agg(ctx, presig, &session, partial_sigs, N_SIGNERS)) {

return 0;
}
if (!secp256k1_musig_adapt(ctx, sig64, presig, adaptor_key, nonce_parity)) {
return 0;
}
/* With sig64 "on-chain" now, other party can grab the revealed adaptor secret */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/* With sig64 "on-chain" now, other party can grab the revealed adaptor secret */
/* With sig64 "on-chain" now, other party can grab the revealed adaptor secret */

wrong indentation

if (!secp256k1_musig_extract_adaptor(ctx, extracted_adaptor, sig64, presig, nonce_parity)) {
return 0;
}
if (memcmp(extracted_adaptor, adaptor_key, sizeof(adaptor_key)) != 0) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you assert this? We normally use assert for these comparisons in the other examples.

return 0;
}
return 1;
}

int main(void) {
Expand Down Expand Up @@ -201,7 +233,7 @@ int sign(const secp256k1_context* ctx, struct signer_secrets *signer_secrets, st
return 1;
}
printf("ok\n");
printf("Verifying signature.....");
printf("Verifying signature and revealed adaptor.....");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we're verifying the adaptor here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

errr extracting revealed secret, I guess is the phrase?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm only saying that the printf not match the code below, which still only verifies a sig.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, I added this in the wrong spot

if (!secp256k1_schnorrsig_verify(ctx, sig, msg, 32, &agg_pk)) {
printf("FAILED\n");
return 1;
Expand Down